From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] spidernet: Fix problem sending IP fragments Date: Sat, 03 Mar 2007 09:21:58 +0100 Message-ID: <1172910118.8184.47.camel@localhost.localdomain> References: <200702281521.34277.n.eicker@fz-juelich.de> <1e548a3f0703011452u6dde9c53ifde2fa41fe5f4c38@mail.gmail.com> <20070301233426.GH4717@austin.ibm.com> <200703021839.16158.n.eicker@fz-juelich.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Linas Vepstas , linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, Adam Emerich , Norbert Eicker To: Geoff Levand Return-path: Received: from gate.crashing.org ([63.228.1.57]:58354 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbXCCIXP (ORCPT ); Sat, 3 Mar 2007 03:23:15 -0500 In-Reply-To: <200703021839.16158.n.eicker@fz-juelich.de> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Geoff, I suspect gelic_net might have the same problem... Cheers, Ben. On Fri, 2007-03-02 at 18:39 +0100, Norbert Eicker wrote: > On Fri 2.3.2007 00:34, Linas Vepstas wrote: > > On Thu, Mar 01, 2007 at 04:52:54PM -0600, Chris Engel wrote: > > > I tried to apply this patch to 2.6.21-rc2 and CHECKSUM_HW appears > > > to be changed to CHECKSUM_COMPLETE > > Oops. I did not test this on the actual 2.6.21-rc2 before sending it. > It worked fine for me on 2.6.18. > > In the meantime it tested the patch below on 2.6.21. > > > The use of CHECKSUM_HW was replaced by CHECKSUM_PARTIAL and > > CHECKSUM_COMPLETE on a cae-by-case basis, in the patch series leading > > up to 2.6.19. In this case, I'm not sure which should have been > > used. > > In fact CHECKSUM_COMPLETE seems to be used on the receiving side while > CHECKSUM_PARTIAL is the one to be used while sending frames. Thus the > latter is the one to chose. > > > Norbert, can you resubmit a patch that applies to a more recent > > kernel? p.s. your emailer replaced tabs by spaces ... > > so here's the new one: > > Fix problem sending IP fragments on spidernet. > > Signed-off-by: Norbert Eicker > --- > diff --git a/drivers/net/spider_net.c b/drivers/net/spider_net.c > index 3b91af8..e3019d5 100644 > --- a/drivers/net/spider_net.c > +++ b/drivers/net/spider_net.c > @@ -719,7 +719,7 @@ spider_net_prepare_tx_descr(struct spide > SPIDER_NET_DESCR_CARDOWNED | SPIDER_NET_DMAC_NOCS; > spin_unlock_irqrestore(&chain->lock, flags); > > - if (skb->protocol == htons(ETH_P_IP)) > + if (skb->protocol == htons(ETH_P_IP) && skb->ip_summed == CHECKSUM_PARTIAL) > switch (skb->nh.iph->protocol) { > case IPPROTO_TCP: > hwdescr->dmac_cmd_status |= SPIDER_NET_DMAC_TCP; > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev