From: Dan Williams <dcbw@redhat.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, stable@kernel.org, jeff@garzik.org,
Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Randy Dunlap <rdunlap@xenotime.net>,
Dave Jones <davej@redhat.com>,
Chuck Wolber <chuckw@quantumlinux.com>,
Chris Wedgwood <reviews@ml.cw.f00f.org>,
Michael Krufky <mkrufky@linuxtv.org>,
Chuck Ebbert <cebbert@redhat.com>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk, netdev@vger.kernel.org,
thomas@archlinux.org, val_henson@linux.intel.com,
samuel.thibault@ens-lyon.org
Subject: Re: [patch 097/101] revert "drivers/net/tulip/dmfe: support basic carrier detection"
Date: Wed, 07 Mar 2007 21:41:51 -0500 [thread overview]
Message-ID: <1173321712.12017.8.camel@localhost.localdomain> (raw)
In-Reply-To: <20070307101444.52cb2146@freekitty>
On Wed, 2007-03-07 at 10:14 -0800, Stephen Hemminger wrote:
> On Wed, 07 Mar 2007 09:12:12 -0800
> Greg KH <gregkh@suse.de> wrote:
>
> >
> > From: Andrew Morton <akpm@linux-foundation.org>
> >
> > Revert 7628b0a8c01a02966d2228bdf741ddedb128e8f8. Thomas Bachler
> > reports:
> >
> > Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe:
> > support basic carrier detection) breaks networking on my Davicom DM9009.
> > ethtool always reports there is no link. tcpdump shows incoming packets,
> > but TX is disabled. Reverting the above patch fixes the problem.
> >
>
> Carrier detection support is important and should be fixed rather than removed.
Definitely right. If it doesn't work for your card, it needs to be
fixed for your card.
Dan
next prev parent reply other threads:[~2007-03-08 2:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070307171035.150802805@mini.kroah.org>
2007-03-07 17:11 ` [patch 029/101] IPV6: HASHTABLES: Use appropriate seed for caluculating ehash index Greg KH
2007-03-07 17:12 ` [patch 097/101] revert "drivers/net/tulip/dmfe: support basic carrier detection" Greg KH
2007-03-07 18:14 ` Stephen Hemminger
2007-03-08 2:41 ` Dan Williams [this message]
2007-03-08 3:06 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173321712.12017.8.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cebbert@redhat.com \
--cc=chuckw@quantumlinux.com \
--cc=davej@redhat.com \
--cc=gregkh@suse.de \
--cc=jeff@garzik.org \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=shemminger@linux-foundation.org \
--cc=stable@kernel.org \
--cc=thomas@archlinux.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=val_henson@linux.intel.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).