From: jamal <hadi@cyberus.ca>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>,
chris@reflexsecurity.com, netdev@vger.kernel.org, tgraf@suug.ch
Subject: Re: Oops in filter add
Date: Wed, 21 Mar 2007 05:33:44 -0400 [thread overview]
Message-ID: <1174469624.16343.2.camel@localhost> (raw)
In-Reply-To: <45FFBE5A.1020807@trash.net>
On Tue, 2007-20-03 at 11:58 +0100, Patrick McHardy wrote:
> jamal wrote:
> > So the resolution (as Dave points out) was wrong. In any case, restoring
> > queue_lock for now would slow things but will remove the race.
>
>
> Yes. I think thats what we should do for 2.6.21, since fixing
> this while keeping ingress_lock is quite intrusive.
>
reasonable.
> I'm on it. I'm using the opportunity to try to simply the qdisc locking.
Ok, thanks Patrick.
BTW, I was just staring at the code and i think i have found probably a
long standing minor bug on the holding of the tree lock. I will post
a patch shortly if i dont get disrupted.
cheers,
jamal
next prev parent reply other threads:[~2007-03-21 9:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 20:10 Oops in filter add Chris Madden
2007-03-20 2:22 ` David Miller
2007-03-20 6:54 ` jamal
2007-03-20 6:58 ` Patrick McHardy
2007-03-20 7:18 ` jamal
2007-03-20 7:29 ` Patrick McHardy
2007-03-20 9:25 ` jamal
2007-03-20 10:54 ` Chris Madden
2007-03-20 11:02 ` Patrick McHardy
2007-03-20 10:58 ` Patrick McHardy
2007-03-21 9:33 ` jamal [this message]
2007-03-20 14:15 ` Chris Madden
2007-03-20 14:48 ` Patrick McHardy
2007-03-20 14:57 ` Patrick McHardy
2007-03-20 15:11 ` Thomas Graf
2007-03-20 15:13 ` Patrick McHardy
2007-03-20 16:27 ` Chris Madden
2007-03-20 17:06 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174469624.16343.2.camel@localhost \
--to=hadi@cyberus.ca \
--cc=chris@reflexsecurity.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).