netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ron Mercer <ron.mercer@qlogic.com>
To: netdev@vger.kernel.org
Cc: ron.mercer@qlogic.com
Subject: [PATCH 4/7] qla3xxx: bugfix: Jumbo frame handling.
Date: Mon, 26 Mar 2007 13:43:00 -0700	[thread overview]
Message-ID: <11749417841489-git-send-email-ron.mercer@qlogic.com> (raw)
In-Reply-To: <20070326164650.GA3822@linux-7mw0.qlogic.org>

Fixed rx checksum bits. Turn on TCP processing for rx checksum.
Fixed max frame length register write.  It wasn't getting set
in multi-port system. Set rx buffer queue length properly
for jumbo frames.

Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
---
 drivers/net/qla3xxx.c |   29 +++++++++++++++--------------
 drivers/net/qla3xxx.h |    3 +--
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index 24c485e..9947a8d 100755
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
@@ -1933,17 +1933,18 @@ static void ql_process_macip_rx_intr(struct ql3_adapter *qdev,
 		u16 checksum = le16_to_cpu(ib_ip_rsp_ptr->checksum);
 		if (checksum & 
 			(IB_IP_IOCB_RSP_3032_ICE | 
-			 IB_IP_IOCB_RSP_3032_CE | 
-			 IB_IP_IOCB_RSP_3032_NUC)) {
+			 IB_IP_IOCB_RSP_3032_CE)) { 
 			printk(KERN_ERR
 			       "%s: Bad checksum for this %s packet, checksum = %x.\n",
 			       __func__,
 			       ((checksum & 
 				IB_IP_IOCB_RSP_3032_TCP) ? "TCP" :
 				"UDP"),checksum);
-		} else if (checksum & IB_IP_IOCB_RSP_3032_TCP) {
+		} else if ((checksum & IB_IP_IOCB_RSP_3032_TCP) ||
+				(checksum & IB_IP_IOCB_RSP_3032_UDP &&
+				!(checksum & IB_IP_IOCB_RSP_3032_NUC))) {
 			skb2->ip_summed = CHECKSUM_UNNECESSARY;
-		} 
+		}
 	}
 	skb2->dev = qdev->ndev;
 	skb2->protocol = eth_type_trans(skb2, qdev->ndev);
@@ -3039,15 +3040,6 @@ static int ql_adapter_initialize(struct ql3_adapter *qdev)
 			goto out;
 		}
 
-		if (qdev->mac_index)
-			ql_write_page0_reg(qdev,
-					   &port_regs->mac1MaxFrameLengthReg,
-					   qdev->max_frame_size);
-		else
-			ql_write_page0_reg(qdev,
-					   &port_regs->mac0MaxFrameLengthReg,
-					   qdev->max_frame_size);
-
 		value = qdev->nvram_data.tcpMaxWindowSize;
 		ql_write_page0_reg(qdev, &port_regs->tcpMaxWindow, value);
 
@@ -3067,6 +3059,14 @@ static int ql_adapter_initialize(struct ql3_adapter *qdev)
 		ql_sem_unlock(qdev, QL_FLASH_SEM_MASK);
 	}
 
+	if (qdev->mac_index)
+		ql_write_page0_reg(qdev,
+				   &port_regs->mac1MaxFrameLengthReg,
+				   qdev->max_frame_size);
+	else
+		ql_write_page0_reg(qdev,
+					   &port_regs->mac0MaxFrameLengthReg,
+					   qdev->max_frame_size);
 
 	if(ql_sem_spinlock(qdev, QL_PHY_GIO_SEM_MASK,
 			(QL_RESOURCE_BITS_BASE_CODE | (qdev->mac_index) *
@@ -3137,7 +3137,8 @@ static int ql_adapter_initialize(struct ql3_adapter *qdev)
 	if (qdev->device_id == QL3032_DEVICE_ID) {
 		value =
 		    (QL3032_PORT_CONTROL_EF | QL3032_PORT_CONTROL_KIE |
-		     QL3032_PORT_CONTROL_EIv6 | QL3032_PORT_CONTROL_EIv4);
+		     QL3032_PORT_CONTROL_EIv6 | QL3032_PORT_CONTROL_EIv4 |
+			QL3032_PORT_CONTROL_ET);
 		ql_write_page0_reg(qdev, &port_regs->functionControl,
 				   ((value << 16) | value));
 	} else {
diff --git a/drivers/net/qla3xxx.h b/drivers/net/qla3xxx.h
index 34cd658..0203f88 100755
--- a/drivers/net/qla3xxx.h
+++ b/drivers/net/qla3xxx.h
@@ -1014,8 +1014,7 @@ struct eeprom_data {
 
 /* Transmit and Receive Buffers */
 #define NUM_LBUFQ_ENTRIES   	128
-#define JUMBO_NUM_LBUFQ_ENTRIES   	\
-(NUM_LBUFQ_ENTRIES/(JUMBO_MTU_SIZE/NORMAL_MTU_SIZE))
+#define JUMBO_NUM_LBUFQ_ENTRIES 32
 #define NUM_SBUFQ_ENTRIES   	64
 #define QL_SMALL_BUFFER_SIZE    32
 #define QL_ADDR_ELE_PER_BUFQ_ENTRY \
-- 
1.5.0.rc4.16.g9e258


  parent reply	other threads:[~2007-03-26 20:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-26 16:46 [PATCH 0/7] qla3xxx: bugfixes and new PHY support Ron Mercer
2007-03-26 19:43 ` [PATCH 1/7] qla3xxx: bugfix: Add tx control block memset Ron Mercer
2007-03-26 19:43 ` [PATCH 2/7] qla3xxx: bugfix: Multi segment sends were getting whacked Ron Mercer
2007-03-26 19:43 ` [PATCH 3/7] qla3xxx: bugfix: Dropping interrupt under heavy network load Ron Mercer
2007-03-26 19:43 ` [PATCH 4/7] qla3xxx: bugfix: Jumbo frame handling Ron Mercer
2007-03-26 19:43 ` [PATCH 5/7] qla3xxx: Add ethtool get_pauseparam for improved bonding support Ron Mercer
2007-03-26 19:43 ` [PATCH 6/7] qla3xxx: Adding support for the Agere PHY (ET1011C) Ron Mercer
2007-03-29 12:35   ` Jeff Garzik
2007-03-26 19:43 ` [PATCH 7/7] qla3xxx: Bumping driver version number to v2.03.00-k4 Ron Mercer
2007-03-26 20:42 ` [PATCH 1/7] qla3xxx: bugfix: Add tx control block memset Ron Mercer
2007-03-28  6:19   ` Jeff Garzik
2007-03-26 20:42 ` [PATCH 2/7] qla3xxx: bugfix: Multi segment sends were getting whacked Ron Mercer
2007-03-26 20:42 ` [PATCH 3/7] qla3xxx: bugfix: Dropping interrupt under heavy network load Ron Mercer
2007-03-26 20:43 ` Ron Mercer [this message]
2007-03-26 20:43 ` [PATCH 5/7] qla3xxx: Add ethtool get_pauseparam for improved bonding support Ron Mercer
2007-03-26 20:43 ` [PATCH 6/7] qla3xxx: Adding support for the Agere PHY (ET1011C) Ron Mercer
2007-03-26 20:43 ` [PATCH 7/7] qla3xxx: Bumping driver version number to v2.03.00-k4 Ron Mercer
2007-03-26 20:47   ` Andrew Vasquez
2007-03-26 20:59     ` Ron Mercer
2007-03-29 12:32       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11749417841489-git-send-email-ron.mercer@qlogic.com \
    --to=ron.mercer@qlogic.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).