From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] Inline net_device_stats
Date: Thu, 29 Mar 2007 10:00:36 +1000 [thread overview]
Message-ID: <1175126436.12230.62.camel@localhost.localdomain> (raw)
In-Reply-To: <460A8F38.1050106@osdl.org>
On Wed, 2007-03-28 at 08:52 -0700, Stephen Hemminger wrote:
> It would make sense to do it per-cpu and 64 bit for the non-error counters.
Well, I looked at the e1000, it doesn't update on every packet anyway,
but seems to d/l from the card occasionally. I assume this is the
method for high-speed drivers, otherwise we should split the tx & rx
parts of the structure.
64 bit introduces potential compatibility problems (exporting via proc).
And per-cpu feels like overkill to me.
Rusty.
prev parent reply other threads:[~2007-03-29 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-28 9:16 [PATCH] Inline net_device_stats Rusty Russell
2007-03-28 15:52 ` Stephen Hemminger
2007-03-28 21:26 ` David Miller
2007-03-29 0:00 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175126436.12230.62.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).