netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Denys <denys@visp.net.lb>
Cc: Patrick McHardy <kaber@trash.net>,
	Stephen Hemminger <shemminger@linux-foundation.org>,
	netdev@vger.kernel.org
Subject: Re: one more... iproute commands lockup whole system
Date: Wed, 04 Apr 2007 06:55:14 -0400	[thread overview]
Message-ID: <1175684114.4088.12.camel@localhost> (raw)
In-Reply-To: <20070404020622.M69215@visp.net.lb>


On Wed, 2007-04-04 at 05:11 +0300, Denys wrote:
> I think this highly useful feature given by jamal, difficult to be avoided 
> from crash, if user not enough experienced in networking(like me). I guess 
> packet can be even not ipv4/ipv6 packet, maybe it can be cloned IPX or ARP, 
> so TTL field cannot be used. I checked maybe sk_buff have some fields, seems 
> also bad luck, if there can be something like "internal" counter for packet, 
> how much times it got redirected, it will help. 

Adding a field in the skb that keeps track of things would work well,
but would be a controvesial thing to do because it actually requires a
vector not just one field. There is a filed called cb[] but it cant be
used in this case because every time we redirect it could be trampled.

> But in my case of VLAN's it 
> is really my own mistake and difficult to avoid it. Only bad thing - machine 
> got completely locked up, and if it is remote system - it will not oops/or 
> reboot even. But i dont have any idea in mind how to avoid this, only than 
> big warning in DOC and internal iproute2 help :-)

Your case is easy to detect in user space because it is within the same
policy.
Would simple detection and rejection in tc/userspace be useful to add?
Note, this doesnt help the general problem though where you have nesting
as described in the document.

cheers,
jamal


  reply	other threads:[~2007-04-04 10:55 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-21 18:00 iproute2-2.6.20-070313 bug ? Denys
2007-03-22 11:23 ` Patrick McHardy
2007-03-22 12:46   ` Denys
2007-03-22 13:09     ` Patrick McHardy
     [not found]       ` <20070322131245.M85528@visp.net.lb>
2007-03-22 13:23         ` Patrick McHardy
2007-03-22 13:35           ` Denys
     [not found]           ` <20070322132637.M88445@visp.net.lb>
2007-03-22 13:43             ` Patrick McHardy
2007-03-22 13:47               ` Denys
2007-03-22 13:26       ` Denys
2007-03-22 17:12       ` Stephen Hemminger
2007-03-22 17:14         ` Patrick McHardy
2007-03-26 18:49           ` more... iproute2/htb/whatever critical " Denys
2007-03-27 15:10             ` Patrick McHardy
2007-03-27 15:18               ` Denys
2007-03-27 16:00               ` Denys
2007-03-27 16:21                 ` Patrick McHardy
2007-03-28 17:38                   ` another " Denys
2007-03-28 23:55                   ` Denys
2007-03-29 10:58                     ` Patrick McHardy
2007-03-31  2:26         ` more iproute2 issues (not critical) Denys
2007-03-31  2:31           ` Denys
2007-03-31 14:16             ` Patrick McHardy
2007-04-04  0:03         ` one more... iproute commands lockup whole system Denys
2007-04-04  1:10           ` jamal
2007-04-04  1:39             ` Patrick McHardy
2007-04-04  2:09               ` jamal
2007-04-04  2:11               ` Denys
2007-04-04 10:55                 ` jamal [this message]
2007-04-04 12:56                   ` Denys
2007-04-04 14:10                     ` jamal
2007-04-04 14:35                       ` Denys
2007-04-04 14:13                     ` HTB/act_mirred problem [was: one more... iproute commands lockup whole system] Patrick McHardy
2007-04-04 14:33                       ` jamal
2007-04-04 14:50                         ` Patrick McHardy
2007-04-05  1:33                           ` jamal
2007-04-04 13:36                   ` one more... iproute commands lockup whole system Patrick McHardy
2007-04-04 13:58                     ` jamal
2007-04-04 14:07                       ` Patrick McHardy
2007-04-04 14:30                         ` jamal
2007-04-04 14:39                           ` Patrick McHardy
2007-04-05  2:14                             ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175684114.4088.12.camel@localhost \
    --to=hadi@cyberus.ca \
    --cc=denys@visp.net.lb \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).