From mboxrd@z Thu Jan 1 00:00:00 1970 From: jamal Subject: Re: HTB/act_mirred problem [was: one more... iproute commands lockup whole system] Date: Wed, 04 Apr 2007 21:33:28 -0400 Message-ID: <1175736808.4068.4.camel@localhost> References: <20070321175951.M73913@visp.net.lb> <46026717.9060909@trash.net> <20070322124533.M79867@visp.net.lb> <46027FF2.6020001@trash.net> <20070322101224.3e6bb899@freekitty> <20070404000054.M58020@visp.net.lb> <1175649016.3957.10.camel@localhost> <461301C0.2050409@trash.net> <20070404020622.M69215@visp.net.lb> <1175684114.4088.12.camel@localhost> <20070404125231.M65138@visp.net.lb> <4613B273.4070801@trash.net> <1175697202.4063.17.camel@localhost> <4613BB23.2050507@trash.net> Reply-To: hadi@cyberus.ca Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Denys , Stephen Hemminger , netdev@vger.kernel.org To: Patrick McHardy Return-path: Received: from wx-out-0506.google.com ([66.249.82.227]:44732 "EHLO wx-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753000AbXDEBdf (ORCPT ); Wed, 4 Apr 2007 21:33:35 -0400 Received: by wx-out-0506.google.com with SMTP id h31so431088wxd for ; Wed, 04 Apr 2007 18:33:34 -0700 (PDT) In-Reply-To: <4613BB23.2050507@trash.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 2007-04-04 at 16:50 +0200, Patrick McHardy wrote: > Anyway, we can't return NET_XMIT_SUCCESS, so how about just returning > NET_XMIT_BYPASS in all cases where the packet was stolen/dropped/... > by TC actions? Ok, I think i get you now. Yes, that would work, but: for the dropped case, you need to record into the dropped stats (unlike the the other two). > > I can > > go back and look at my notes to be certain. At one point i posted those > > notes, it maybe time to add them to the kernel code or doc somewhere. > > > In case they're still up to date, adding them somewhere under > Documentation/ sounds good. I think it is still uotodate, if not i will make sure it is before i submit it. cheers, jamal