From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [PATCH] net: Add etun driver Date: Tue, 10 Apr 2007 23:16:59 +0200 Message-ID: <1176239819.10381.10.camel@johannes.berg> References: <1176136628.8459.34.camel@johannes.berg> <461A70A5.8060607@trash.net> <20070409.114402.45491411.davem@davemloft.net> <461A9DF1.8080904@trash.net> <1176150557.8459.47.camel@johannes.berg> <461AD517.2000906@trash.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-TJUVvMleZmXqDukrANvE" Cc: "Eric W. Biederman" , David Miller , akpm@linux-foundation.org, dim@openvz.org, netdev@vger.kernel.org, jgarzik@pobox.com, containers@lists.osdl.org, kuznet@ms2.inr.ac.ru, shemminger@linux-foundation.org, greearb@candelatech.com To: Patrick McHardy Return-path: Received: from crystal.sipsolutions.net ([195.210.38.204]:33425 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752082AbXDKLHA (ORCPT ); Wed, 11 Apr 2007 07:07:00 -0400 In-Reply-To: <461AD517.2000906@trash.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org --=-TJUVvMleZmXqDukrANvE Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2007-04-10 at 02:06 +0200, Patrick McHardy wrote: > Same way as the current RTM_SETLINK message works, but with creating > a new link in advance. It works fine in other subsystems, so I don't > see why it would in this case as well. Some subsystems do it in an > atomic fashion (network schedulers for example), some first create > the object, then configure it (network classifiers in the non-compat > cases). In the network device case I suppose the later should work > fine since a device needs to be set UP in a second action before > it really does anything. Looking at br_netlink.c it seems that this sort of contradicts why generic netlink was done, now all the sudden everything that wants to create new links need its own netlink protocol number, no? johannes --=-TJUVvMleZmXqDukrANvE Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Comment: Johannes Berg (powerbook) iD8DBQBGG/7L/ETPhpq3jKURAkHEAJ9kdvCDE0rZlhbQ4R2vzdcqYs+gSQCgqlGm ypyEg4vN09clN0LFGfitAsk= =Vjn9 -----END PGP SIGNATURE----- --=-TJUVvMleZmXqDukrANvE--