From: jamal <hadi@cyberus.ca>
To: Laurent Chavey <chavey@google.com>
Cc: netdev@vger.kernel.org
Subject: Re: is CONFIG_NET_CLS_ACT always set ?
Date: Mon, 23 Apr 2007 20:02:57 -0400 [thread overview]
Message-ID: <1177372977.4096.24.camel@localhost> (raw)
In-Reply-To: <97949e3e0704231608n6f43807en1ee6e27265c641ba@mail.gmail.com>
On Mon, 2007-23-04 at 16:08 -0700, Laurent Chavey wrote:
> sorry for the trick question.
>
> I was simply making a modification to the skb tap code
> to allow tcpdump to work on the slave interface and not
> just the bonded one.
If you dont mind: what is the goal? I am not sure i want to see the
packets on a backup interface in a bond active/backup - but you may
have some good reason.
> The code change requires a change to
> the for loop code and it follow on to the call to deliver_skb().
>
Iam assuming you have taken care of the code above that which drops the
packet if not destined for master?
> In the process of adding the code, I noticed that if (at least
> that is how I read the code)
> CONFIG_NET_CLS_ACT is not defined then
> the last pt_prev is call after the diverter and bridge code
> have handled the skb. This would only occur for bridged skb
> that one wanted to tap.
>
The bridge code does the right thing if you follow handle bridge.
The old diverter (you must be looking at an old kernel, because it is
gone) was supposed to be able to steal packets.
I am not sure if that answers your question.
cheers,
jamal
next prev parent reply other threads:[~2007-04-24 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 21:19 is CONFIG_NET_CLS_ACT always set ? Laurent Chavey
2007-04-23 22:59 ` jamal
2007-04-23 23:08 ` Laurent Chavey
2007-04-24 0:02 ` jamal [this message]
2007-04-24 20:33 ` Laurent Chavey
2007-04-24 23:03 ` Laurent Chavey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1177372977.4096.24.camel@localhost \
--to=hadi@cyberus.ca \
--cc=chavey@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).