From: Rusty Russell <rusty@rustcorp.com.au>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: netfront for review
Date: Wed, 02 May 2007 14:23:02 +1000 [thread overview]
Message-ID: <1178079783.28659.183.camel@localhost.localdomain> (raw)
In-Reply-To: <20070502035127.GA28090@gondor.apana.org.au>
On Wed, 2007-05-02 at 13:51 +1000, Herbert Xu wrote:
> On Wed, May 02, 2007 at 01:37:13PM +1000, Rusty Russell wrote:
> >
> > > +static int xennet_change_mtu(struct net_device *dev, int mtu)
> > > +{
> > > + int max = xennet_can_sg(dev) ? 65535 - ETH_HLEN : ETH_DATA_LEN;
> >
> > This seems odd to me: just because a device does TSO should we really
> > allow huge mtu settings? Herbert?
>
> Actually this has nothing to do with TSO/GSO. This driver inherently
> supports arbitrary MTUs that's only limited by our network stack. If
> the physical network device can't handle it you'll just get an ICMP
> error back or fragmentation.
Oops, I misread "xennet_can_sg" as a test for GSO.
Thanks for the clarification,
Rusty.
next prev parent reply other threads:[~2007-05-02 4:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4637D672.5030706@goop.org>
2007-05-02 3:37 ` netfront for review Rusty Russell
2007-05-02 3:51 ` Herbert Xu
2007-05-02 4:23 ` Rusty Russell [this message]
2007-05-02 4:18 ` Jeremy Fitzhardinge
2007-05-02 19:47 ` Jeremy Fitzhardinge
2007-05-03 7:33 ` Gerd Hoffmann
2007-05-03 14:27 ` Jeremy Fitzhardinge
2007-05-03 14:30 ` Keir Fraser
2007-05-03 14:34 ` Gerd Hoffmann
2007-05-03 15:17 ` Christoph Hellwig
2007-05-03 15:38 ` Gerd Hoffmann
2007-05-03 16:00 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178079783.28659.183.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=herbert@gondor.apana.org.au \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).