* [PATCH 3/11][TG3]: Clear GPIO mask before storing.
@ 2007-05-05 0:52 Michael Chan
2007-05-05 18:51 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Michael Chan @ 2007-05-05 0:52 UTC (permalink / raw)
To: davem, netdev
[TG3]: Clear GPIO mask before storing.
The GPIO settings may change during reset and so the stored values in
tp->grc_local_ctrl should be cleared first.
Signed-off-by: Gary Zambrano <zambrano@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index c01bd86..00027a1 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -6454,6 +6454,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755)
gpio_mask |= GRC_LCLCTRL_GPIO_UART_SEL;
+ tp->grc_local_ctrl &= ~gpio_mask;
tp->grc_local_ctrl |= tr32(GRC_LOCAL_CTRL) & gpio_mask;
/* GPIO1 must be driven high for eeprom write protect */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/11][TG3]: Clear GPIO mask before storing.
2007-05-05 0:52 [PATCH 3/11][TG3]: Clear GPIO mask before storing Michael Chan
@ 2007-05-05 18:51 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-05-05 18:51 UTC (permalink / raw)
To: mchan; +Cc: netdev
From: "Michael Chan" <mchan@broadcom.com>
Date: Fri, 04 May 2007 17:52:38 -0700
> [TG3]: Clear GPIO mask before storing.
>
> The GPIO settings may change during reset and so the stored values in
> tp->grc_local_ctrl should be cleared first.
>
> Signed-off-by: Gary Zambrano <zambrano@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-05 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-05 0:52 [PATCH 3/11][TG3]: Clear GPIO mask before storing Michael Chan
2007-05-05 18:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).