From: Dan Williams <dcbw@redhat.com>
To: matthieu castet <castet.matthieu@free.fr>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org
Subject: Re: RFC airo : wpa support
Date: Sun, 06 May 2007 21:45:36 -0400 [thread overview]
Message-ID: <1178502336.25436.3.camel@localhost.localdomain> (raw)
In-Reply-To: <463BB946.3000807@free.fr>
On Sat, 2007-05-05 at 00:52 +0200, matthieu castet wrote:
> Hi,
>
> I attach a diff against 2.6.21 for adding wpa support for airo driver.
> In then end of 2005 I manage to make work wpa but the code was really
> ugly. I manage to find some time to clean it.
>
>
> To support wpa, a new interface of the firmware should be used. This
> interface is incompatible with the old interface and using both
> interface at the same time make the firmware hang.
>
> Porting OPEN and WEP mode to new interface need some driver rewrite, and
> the old interface should be keep for the older cards (or the cards that
> doesn't have newer firmware).
> That's why I didn't do it, and I added a module parameter for choosing
> between the old driver behavior (with no wpa support) or the driver with
> wpa only support.
Nice, thanks for cleaning it up. However, having a module option for
WPA vs. no WPA gets a big, big NAK from me. We need to be able to have
it all co-exist. I'll see if I can clean it up and make the modes able
to function in parallel.
> The wireless extension handlers are a bit ugly, I will be very happy, if
> somebody could help me to clean them.
I can take a shot at it.
Dan
> Any comments are appreciated.
>
>
> Matthieu
>
>
> PS : the lastest version of the driver can be found in
> http://svn.gna.org/viewcvs/airo-wpa/branches/kernel/
>
> PS2 : There is some remaining trace in the driver for debug purpose,
> that will be removed in the final version
next prev parent reply other threads:[~2007-05-07 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 22:52 RFC airo : wpa support matthieu castet
2007-05-07 1:45 ` Dan Williams [this message]
2007-06-11 15:18 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178502336.25436.3.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=castet.matthieu@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).