From: jamal <hadi@cyberus.ca>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, krkumar2@in.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH] sched: Optimize return value of qdisc_restart
Date: Thu, 10 May 2007 09:18:04 -0400 [thread overview]
Message-ID: <1178803084.4074.48.camel@localhost> (raw)
In-Reply-To: <E1Hm8Ey-0006oe-00@gondolin.me.apana.org.au>
On Thu, 2007-10-05 at 22:59 +1000, Herbert Xu wrote:
> jamal <hadi@cyberus.ca> wrote:
> This release qlock isn't in our source code :)
This is why i defered this to you ;->
For completion sake, this is how it looks like:
CPU0 CPU1
| wait qlock |
| |
| + find that return code is 0
| + release qdisc running
| + release qlock
+ grab qlock + ==> outta here
| enq pktx |
| call qdisc_run |
+ grab running
| deq etc
+ release running
+ release qlock
+ ==> outta here
I wonder how much performance improvement this give now that the extra
incursion into qdisc_restart is avoided.
cheers,
jamal
next prev parent reply other threads:[~2007-05-10 13:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 7:31 [PATCH] sched: Optimize return value of qdisc_restart Krishna Kumar
2007-05-09 2:05 ` David Miller
2007-05-09 4:35 ` Krishna Kumar2
2007-05-09 6:36 ` David Miller
2007-05-09 7:23 ` Krishna Kumar2
2007-05-09 8:12 ` David Miller
2007-05-09 12:56 ` jamal
2007-05-09 14:47 ` Krishna Kumar2
2007-05-09 15:52 ` jamal
2007-05-10 5:12 ` Krishna Kumar2
2007-05-10 11:50 ` Herbert Xu
2007-05-10 11:55 ` David Miller
2007-05-10 12:10 ` Herbert Xu
2007-05-10 21:11 ` David Miller
2007-05-10 12:21 ` jamal
2007-05-10 12:50 ` jamal
2007-05-10 12:59 ` Herbert Xu
2007-05-10 13:18 ` jamal [this message]
2007-05-10 13:52 ` Herbert Xu
2007-05-10 14:12 ` jamal
2007-05-10 14:26 ` Krishna Kumar2
2007-05-10 14:31 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178803084.4074.48.camel@localhost \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).