netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Thomas Graf <tgraf@suug.ch>
Cc: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: Re: take 2 WAS (RE: [RFC] make qdisc_restart more readable
Date: Sat, 12 May 2007 07:58:29 -0400	[thread overview]
Message-ID: <1178971110.4061.1.camel@localhost> (raw)
In-Reply-To: <20070512094629.GJ521@postel.suug.ch>

On Sat, 2007-12-05 at 11:46 +0200, Thomas Graf wrote:

> > +	struct sk_buff *skb = NULL;
> > +
> > +	if (skb = dev->gso_skb) 
> 
> This must have caused a warning 

Possibly (dont recall) - i will move the assignment to the first line.

> and you probably want to inline this function.

will do.

Thanks Thomas.

cheers,
jamal


  reply	other threads:[~2007-05-12 11:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-11  0:13 [RFC] make qdisc_restart more readable jamal
2007-05-11 15:56 ` Waskiewicz Jr, Peter P
2007-05-11 18:04   ` jamal
2007-05-11 18:13     ` Waskiewicz Jr, Peter P
2007-05-11 18:35       ` jamal
2007-05-11 18:46         ` Waskiewicz Jr, Peter P
2007-05-11 19:29           ` take 2 WAS (RE: " jamal
2007-05-11 22:01             ` Waskiewicz Jr, Peter P
2007-05-11 22:43               ` jamal
2007-05-12  9:46             ` Thomas Graf
2007-05-12 11:58               ` jamal [this message]
2007-05-12 12:18             ` take 3 " jamal
2007-05-12 17:02               ` Patrick McHardy
2007-05-12 19:56                 ` jamal
2007-05-13 14:28                   ` [LAST CALL] [PATCH] [NET_SCHED]make " jamal
2007-05-14 10:40                     ` Patrick McHardy
2007-05-14 12:41                       ` jamal
2007-05-14 12:43                         ` Patrick McHardy
2007-05-14 13:30                     ` jamal
2007-05-14 20:09                       ` Waskiewicz Jr, Peter P
2007-05-16 22:55                       ` jamal
2007-05-16 23:00                         ` David Miller
2007-05-16 23:15                         ` Sridhar Samudrala
2007-05-17  2:12                           ` jamal
2007-05-11 17:01 ` [RFC] make " Thomas Graf
2007-05-11 18:11   ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1178971110.4061.1.camel@localhost \
    --to=hadi@cyberus.ca \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).