From: jamal <hadi@cyberus.ca>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>,
Peter P <peter.p.waskiewicz.jr@intel.com>,
Thomas Graf <tgraf@suug.ch>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, Sridhar Samudrala <sri@us.ibm.com>,
Auke <auke-jan.h.kok@intel.com>,
Krishna Kumar2 <krkumar2@in.ibm.com>,
xma@us.ibm.com
Subject: Re: [RESEND][PATCH] [NET_SCHED]make qdisc_restart more readable
Date: Thu, 24 May 2007 09:38:33 -0400 [thread overview]
Message-ID: <1180013913.4092.7.camel@localhost> (raw)
In-Reply-To: <46550965.5000400@trash.net>
On Thu, 2007-24-05 at 05:41 +0200, Patrick McHardy wrote:
> jamal wrote:
> > + if (unlikely (ret != NETDEV_TX_BUSY && net_ratelimit()))
> > + printk(KERN_DEBUG " BUG %s code %d qlen %d\n",dev->name, ret, q->q.qlen);
>
>
> This seems to be based on an old version, your latest patch
> changed this to KERN_WARNING.
sigh.
I wont be able to do this change until tonight or tommorow morning. I
think the process i am using to re-generate patches maybe too consuming?
Maybe you could offer some advice. Heres what i do:
1. clone Daves latest tree localy
2. clone another tree from that
3. create patch on second clone
4. compile; test;compile;test until looks reasonable
5. commit with the comments
6. submit
7. build other patches on top (example batching in this case)
8. feedback on patch comes back
9. Re-do steps #2-#6
My steps #2-#6 are expensive; is there a way to optimize that process?
cheers,
jamal
next prev parent reply other threads:[~2007-05-24 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 2:15 [RESEND][PATCH] [NET_SCHED]make qdisc_restart more readable jamal
2007-05-24 3:41 ` Patrick McHardy
2007-05-24 13:38 ` jamal [this message]
2007-05-24 15:48 ` Waskiewicz Jr, Peter P
2007-05-24 16:13 ` Patrick McHardy
2007-05-25 1:52 ` jamal
2007-05-25 1:58 ` jamal
2007-05-25 2:03 ` David Miller
2007-05-25 2:10 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180013913.4092.7.camel@localhost \
--to=hadi@cyberus.ca \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sri@us.ibm.com \
--cc=tgraf@suug.ch \
--cc=xma@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).