From: Doug Chapman <doug.chapman@hp.com>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: jeff@garzik.org, herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [PATCH] e1000: disable polling before registering netdevice
Date: Fri, 01 Jun 2007 18:37:48 -0400 [thread overview]
Message-ID: <1180737468.26001.1.camel@athlon> (raw)
In-Reply-To: <20070601172239.12639.92139.stgit@localhost.localdomain>
On Fri, 2007-06-01 at 10:22 -0700, Auke Kok wrote:
> To assure the symmetry of poll enable/disable in up/down, we should
> initialize the netdevice to be poll_disabled at load time. Doing
> this after register_netdevice leaves us open to another race, so
> lets move all the netif_* calls above register_netdevice so the
> stack starts out how we expect it to be.
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Doug Chapman <doug.chapman@hp.com>
I tested this on my HP Integrity systems and it looks good.
thanks,
- Doug
next prev parent reply other threads:[~2007-06-01 22:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 17:22 [PATCH] e1000: disable polling before registering netdevice Auke Kok
2007-06-01 22:15 ` Herbert Xu
2007-06-01 22:37 ` Doug Chapman [this message]
2007-06-03 15:47 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180737468.26001.1.camel@athlon \
--to=doug.chapman@hp.com \
--cc=auke-jan.h.kok@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).