From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink Date: Mon, 02 Jul 2007 10:43:41 +0200 Message-ID: <1183365821.4089.94.camel@johannes.berg> References: <1179827251.7707.29.camel@localhost.localdomain> <1179831825.4121.30.camel@localhost> <1180258853.7707.53.camel@localhost.localdomain> <4466a10705270629h31977813hd2fc8330bcd87f78@mail.gmail.com> <4466a10705270634j3560c9a3j9c3630ddc20a24aa@mail.gmail.com> <1181811576.5411.27.camel@localhost.localdomain> <1181820510.4091.9.camel@localhost> <1181869285.5411.39.camel@localhost.localdomain> <1182178882.4063.11.camel@localhost> <1182223964.5411.76.camel@localhost.localdomain> <1182811210.6644.22.camel@johannes.berg> <1182986681.5155.55.camel@localhost> <1183121869.4089.57.camel@johannes.berg> <468504FE.9000502@trash.net> <1183122920.4089.63.camel@johannes.berg> <468507C9.2000800@trash.net> <1183124085.4089.66.camel@johannes.berg> <46850CB8.8000509@trash.net> <1183124981.4089.69.camel@johannes.berg> <46850EDE.5020804@trash.net> <1183125924.4089.73.camel@johannes.berg> <1183126739.4089.76.camel@johannes.berg> <1183129006.4089.84.camel@johannes.berg> <1183217536.5165.25.camel@localhost> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-y+Z5QCL/K0zrec3qDGJZ" Cc: Patrick McHardy , Zhang Rui , netdev@vger.kernel.org, "linux-acpi@vger" , lenb@kernel.org, Thomas Graf To: hadi@cyberus.ca Return-path: In-Reply-To: <1183217536.5165.25.camel@localhost> Sender: linux-acpi-owner@vger.kernel.org List-Id: netdev.vger.kernel.org --=-y+Z5QCL/K0zrec3qDGJZ Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2007-06-30 at 11:32 -0400, jamal wrote: > > +static void genl_unregister_mc_group(struct genl_multicast_group *grp) > > +{ > > + /* > > + * TODO: fix multicast group re-use by clearing the bit > > + * for this group in all genetlink sockets. > > + */ > > + clear_bit(grp->id, mc_groups); > > + list_del(&grp->list); >=20 > I think you need a=20 > genl_ctrl_event(CTRL_CMD_DELMCAST_GRP, family); > here? You may need to save the mcast details before you delete. I will, but not currently because right now mcast groups are only deleted when the family is dropped. > > + NLA_PUT_U32(skb, CTRL_ATTR_MCAST_GRP_ID, grp->id); > > + NLA_PUT_STRING(skb, CTRL_ATTR_MCAST_GRP_NAME, > > + grp->name); > > + >=20 > Consider my earlier suggestion to use CTRL_ATTR_MCAST_GRP which has both > id and name in one struct. Yeah I thought about that but then saw Patrick's patches to convert other things away from structs so I wasn't sure what the idea here is. Patrick, care to comment? > Other than that - looking good. :) johannes --=-y+Z5QCL/K0zrec3qDGJZ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Comment: Johannes Berg (powerbook) iD8DBQBGiLq9/ETPhpq3jKURAk7SAJ0Q97DJhEE4b/ozZtscZP4kmdl9cQCfbR2k 4SVPf6JujQTM6Np8m96EbTE= =5J4b -----END PGP SIGNATURE----- --=-y+Z5QCL/K0zrec3qDGJZ--