From mboxrd@z Thu Jan 1 00:00:00 1970 From: jamal Subject: Re: [WIP][PATCHES] Network xmit batching - tg3 support Date: Tue, 03 Jul 2007 21:59:48 -0400 Message-ID: <1183514388.5174.29.camel@localhost> References: <1181216629.4064.22.camel@localhost> <20070619132148.GA32078@2ka.mipt.ru> <20070619133333.GA19667@2ka.mipt.ru> <20070619140038.GA13629@2ka.mipt.ru> <1182270529.4968.73.camel@localhost> <18040.5105.715624.286924@robur.slu.se> <1182275300.4968.83.camel@localhost> <1182989145.5155.81.camel@localhost> <1183411245.6609.16.camel@teletran1> <1183468188.5159.73.camel@localhost> <1183491084.14005.27.camel@teletran1> Reply-To: hadi@cyberus.ca Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Robert Olsson , Evgeniy Polyakov , Krishna Kumar2 , Gagan Arneja , netdev@vger.kernel.org, Rick Jones , Sridhar Samudrala , David Miller , Jeff Garzik , Michael Chan To: Matt Carlson Return-path: Received: from wx-out-0506.google.com ([66.249.82.229]:28835 "EHLO wx-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755215AbXGDB7v (ORCPT ); Tue, 3 Jul 2007 21:59:51 -0400 Received: by wx-out-0506.google.com with SMTP id h31so1958735wxd for ; Tue, 03 Jul 2007 18:59:51 -0700 (PDT) In-Reply-To: <1183491084.14005.27.camel@teletran1> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 2007-03-07 at 12:31 -0700, Matt Carlson wrote: > I had planned on using netperf, but pktgen sounds like a more controlled > environment. Thanks for the tip. I can help more if you use pktgen - netperf is more involved. Also pktgen is much closer to the driver so it would let you see closely if any improvements are obvious or not. > Do you see any reason why we couldn't just add the VLAN code to the prep > stage and simply overwrite that portion of the skb-cb? Our driver would > just store its value in the base_flags member of tg3_tx_cbdata. That would be a much better approach;-> Go for it. cheers, jamal