From: jamal <hadi@cyberus.ca>
To: Matt Carlson <mcarlson@broadcom.com>
Cc: Robert Olsson <Robert.Olsson@data.slu.se>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
Krishna Kumar2 <krkumar2@in.ibm.com>,
Gagan Arneja <gaagaan@gmail.com>,
netdev@vger.kernel.org, Rick Jones <rick.jones2@hp.com>,
Sridhar Samudrala <sri@us.ibm.com>,
David Miller <davem@davemloft.net>, Jeff Garzik <jeff@garzik.org>,
Michael Chan <mchan@broadcom.com>
Subject: Re: [PATCH v2] tg3: Tx availability fix
Date: Fri, 06 Jul 2007 09:14:40 -0400 [thread overview]
Message-ID: <1183727680.5155.12.camel@localhost> (raw)
In-Reply-To: <1183683561.24582.76.camel@teletran1>
Matt,
I have applied both changes (and updated the git tree) with a small
caveat on the second patch:
On Thu, 2007-05-07 at 17:59 -0700, Matt Carlson wrote:
> The last change makes sure that new xmit_win values, as assigned by the
> transmit queue wake code, will not be drastically larger than the value
> set during initialization.
I have left out the above change i.e i kept it as
dev->xmit_win = tp->tx_pending
If you dont mind lets keep it that way for now so we dont introduce any
new variables. i.e. thats how i have been testing and collecting
results.
If you run some tests and come up with better results by using a /4 i
would be more than happy to add it back.
Thanks very much for all your efforts - Broadcom rocks.
cheers,
jamal
prev parent reply other threads:[~2007-07-06 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 0:23 [PATCH] tg3: Tx availability fix Matt Carlson
2007-07-06 0:59 ` [PATCH v2] " Matt Carlson
2007-07-06 13:14 ` jamal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183727680.5155.12.camel@localhost \
--to=hadi@cyberus.ca \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@davemloft.net \
--cc=gaagaan@gmail.com \
--cc=jeff@garzik.org \
--cc=johnpol@2ka.mipt.ru \
--cc=krkumar2@in.ibm.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).