From: Johannes Berg <johannes@sipsolutions.net>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] CXGB3: Replace kcalloc(1,...) with kmalloc() in cxgb3_offload.c.
Date: Sun, 08 Jul 2007 12:08:49 +0200 [thread overview]
Message-ID: <1183889330.3771.0.camel@johannes.berg> (raw)
In-Reply-To: <Pine.LNX.4.64.0707080537360.7944@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
On Sun, 2007-07-08 at 05:39 -0400, Robert P. J. Day wrote:
> - t = kcalloc(1, sizeof(*t), GFP_KERNEL);
> + t = kcalloc(sizeof(*t), GFP_KERNEL);
^
I don't think that's going to work, and shouldn't it probably use
kzalloc instead of kmalloc (as you wrote in subject)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
prev parent reply other threads:[~2007-07-08 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 9:39 [PATCH] CXGB3: Replace kcalloc(1,...) with kmalloc() in cxgb3_offload.c Robert P. J. Day
2007-07-08 10:08 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183889330.3771.0.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox