From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bryan Wu Subject: Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver Date: Sun, 15 Jul 2007 20:10:30 +0800 Message-ID: <1184501430.3140.75.camel@roc-laptop> References: <1184491629.3140.59.camel@roc-laptop> <200707151236.51779.mb@bu3sch.de> <20070715105358.GA18177@infradead.org> Reply-To: bryan.wu@analog.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Michael Buesch , bryan.wu@analog.com, Mike Frysinger , Jeff Garzik , Andrew Morton , LKML , netdev@vger.kernel.org To: Christoph Hellwig Return-path: Received: from nwd2mail11.analog.com ([137.71.25.57]:2009 "EHLO nwd2mail11.analog.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757994AbXGOMKg (ORCPT ); Sun, 15 Jul 2007 08:10:36 -0400 In-Reply-To: <20070715105358.GA18177@infradead.org> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sun, 2007-07-15 at 11:53 +0100, Christoph Hellwig wrote: > On Sun, Jul 15, 2007 at 12:36:51PM +0200, Michael Buesch wrote: > > On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: > > > +#if defined(CONFIG_BFIN_MAC_USE_L1) > > > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) > > > +# define bfin_mac_free(dma_handle, ptr) l1_data_sram_free(ptr) > > > +#else > > > +# define bfin_mac_alloc(dma_handle, size) \ > > > + dma_alloc_coherent(NULL, size, dma_handle, GFP_NORMAL) > > > > What is GFP_NORMAL? It's not defined in latest linus' tree. > > I think you should use GFP_KERNEL, if you can sleep, or GFP_ATOMIC, > > if you can't. > > Actually this whole thing looks fishy. There should be a struct device > for the dma allocation, through a platform_device. And the > CONFIG_BFIN_MAC_USE_L1 should go away, the l1 sram should have a dma > provider so this can be handled through the dma api. We do have L1 memory DMA allocator and manager, it is depends on Blackfin arch. And this driver is Blackfin on-chip ethernet MAC controller. So it is OK, any idea? Thanks - Bryan Wu