From: Richard Purdie <rpurdie@rpsys.net>
To: Patrick McHardy <kaber@trash.net>
Cc: Florian Fainelli <florian.fainelli@telecomint.eu>,
netdev@vger.kernel.org
Subject: Re: [PATCH] Add a network activity LED trigger
Date: Wed, 18 Jul 2007 15:10:44 +0100 [thread overview]
Message-ID: <1184767844.21219.3.camel@localhost.localdomain> (raw)
In-Reply-To: <469E1BB0.2040104@trash.net>
On Wed, 2007-07-18 at 15:54 +0200, Patrick McHardy wrote:
> Florian Fainelli wrote:
> >> Besides missing a declaration and not linking without the network
> >> LED config option, its pretty ridiculous to call this for every
> >> packet just to make a led blink.
> >>
> >
> > Could you suggest me a better way to do so ? The code was highly inspired from
> > what is done with the IDE trigger. The declaration is done in linux/leds.h,
> > which is included in dev.c for that purpose.
> >
>
> Maybe just increment a variable and periodically check it or something
> like that.
Are there not already packet counters that the LED trigger could just
look at? If it did that at say 20Hz or 10Hz, it would probably look
quite reasonable without impacting on the system too much?
Richard
next prev parent reply other threads:[~2007-07-18 14:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 13:27 [PATCH] Add a network activity LED trigger Florian Fainelli
2007-07-18 13:33 ` Patrick McHardy
2007-07-18 13:44 ` Florian Fainelli
2007-07-18 13:54 ` Patrick McHardy
2007-07-18 14:10 ` Richard Purdie [this message]
2007-07-18 14:14 ` Patrick McHardy
2007-07-18 22:22 ` David Miller
2007-07-18 13:41 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184767844.21219.3.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=florian.fainelli@telecomint.eu \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).