From: Denis Cheng <crquan@gmail.com>
To: Paul Clements <Paul.Clements@steeleye.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>,
Steven Whitehouse <steve@chygwyn.com>,
Andrew Morton <akpm@linux-foundation.org>,
Denis Cheng <crquan@gmail.com>
Subject: [PATCH 2/2] nbd: change a parameter's type to remove a memcpy call
Date: Thu, 19 Jul 2007 17:34:31 +0800 [thread overview]
Message-ID: <11848377013773-git-send-email-crquan@gmail.com> (raw)
In-Reply-To: <11848376711601-git-send-email-crquan@gmail.com>
this memcpy looks so strange, in fact it's merely a pointer dereference,
so I change the parameter's type to refer it more directly,
this could make the memcpy not needed anymore.
in the function nbd_read_stat where nbd_find_request is only once called,
the parameter served should be transformed accordingly.
Signed-off-by: Denis Cheng <crquan@gmail.com>
---
drivers/block/nbd.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 86639c0..a4d8508 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -235,14 +235,11 @@ error_out:
return 1;
}
-static struct request *nbd_find_request(struct nbd_device *lo, char *handle)
+static struct request *nbd_find_request(struct nbd_device *lo, struct request *xreq)
{
struct request *req, *n;
- struct request *xreq;
int err;
- memcpy(&xreq, handle, sizeof(xreq));
-
err = wait_event_interruptible(lo->active_wq, lo->active_req != xreq);
if (unlikely(err))
goto out;
@@ -297,7 +294,7 @@ static struct request *nbd_read_stat(struct nbd_device *lo)
goto harderror;
}
- req = nbd_find_request(lo, reply.handle);
+ req = nbd_find_request(lo, *(struct request **)reply.handle);
if (unlikely(IS_ERR(req))) {
result = PTR_ERR(req);
if (result != -ENOENT)
--
1.5.2.2
next prev parent reply other threads:[~2007-07-19 9:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 9:34 [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable Denis Cheng
2007-07-19 9:34 ` Denis Cheng [this message]
2007-07-19 17:35 ` [PATCH 2/2] nbd: change a parameter's type to remove a memcpy call Paul Clements
2007-07-20 1:46 ` rae l
2007-07-19 15:12 ` [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable Paul Clements
2007-07-19 15:55 ` rae l
2007-07-19 16:48 ` rae l
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11848377013773-git-send-email-crquan@gmail.com \
--to=crquan@gmail.com \
--cc=Paul.Clements@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=steve@chygwyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).