From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denis Cheng Subject: [PATCH 2/2] nbd: change a parameter's type to remove a memcpy call Date: Thu, 19 Jul 2007 17:34:31 +0800 Message-ID: <11848377013773-git-send-email-crquan@gmail.com> References: <11848376711601-git-send-email-crquan@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek , Steven Whitehouse , Andrew Morton , Denis Cheng To: Paul Clements Return-path: Received: from qb-out-0506.google.com ([72.14.204.237]:35445 "EHLO qb-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755287AbXGSJfO (ORCPT ); Thu, 19 Jul 2007 05:35:14 -0400 Received: by qb-out-0506.google.com with SMTP id e11so1095850qbe for ; Thu, 19 Jul 2007 02:35:13 -0700 (PDT) In-Reply-To: <11848376711601-git-send-email-crquan@gmail.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org this memcpy looks so strange, in fact it's merely a pointer dereference, so I change the parameter's type to refer it more directly, this could make the memcpy not needed anymore. in the function nbd_read_stat where nbd_find_request is only once called, the parameter served should be transformed accordingly. Signed-off-by: Denis Cheng --- drivers/block/nbd.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 86639c0..a4d8508 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -235,14 +235,11 @@ error_out: return 1; } -static struct request *nbd_find_request(struct nbd_device *lo, char *handle) +static struct request *nbd_find_request(struct nbd_device *lo, struct request *xreq) { struct request *req, *n; - struct request *xreq; int err; - memcpy(&xreq, handle, sizeof(xreq)); - err = wait_event_interruptible(lo->active_wq, lo->active_req != xreq); if (unlikely(err)) goto out; @@ -297,7 +294,7 @@ static struct request *nbd_read_stat(struct nbd_device *lo) goto harderror; } - req = nbd_find_request(lo, reply.handle); + req = nbd_find_request(lo, *(struct request **)reply.handle); if (unlikely(IS_ERR(req))) { result = PTR_ERR(req); if (result != -ENOENT) -- 1.5.2.2