From: Rusty Russell <rusty@rustcorp.com.au>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org,
jgarzik@pobox.com
Subject: Re: [PATCH]: Resurrect napi_poll patch.
Date: Sat, 21 Jul 2007 17:14:31 +1000 [thread overview]
Message-ID: <1185002071.6344.21.camel@localhost.localdomain> (raw)
In-Reply-To: <20070720.223129.59470764.davem@davemloft.net>
On Fri, 2007-07-20 at 22:31 -0700, David Miller wrote:
> Stephen asked me if I could resurrect the last version of
> his napi_poll patch that I posted a long time ago, I finally
> got to that tonight.
>
> Basically, this disconnects the ->poll() object from the net
> device. This will allow drivers to handle multi RX queues
> cleanly without creating fake net_device objects and crap
> like that.
Hi Dave,
This looks good! It might be nice though to go further and remove the
internal napi_struct. It's kind of a wart for multi-queue drivers which
are going to have their own array (or whatever).
But I can do that as a separate patch if you think it's a decent idea.
The name "NAPI" is also a wart, but I guess it's everywhere now so one
more place isn't making things worse...
Cheers,
Rusty.
next prev parent reply other threads:[~2007-07-21 7:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 5:31 [PATCH]: Resurrect napi_poll patch David Miller
2007-07-21 5:46 ` Patrick McHardy
2007-07-21 6:00 ` David Miller
2007-07-21 7:14 ` Rusty Russell [this message]
2007-07-21 7:42 ` David Miller
2007-07-21 8:00 ` Rusty Russell
2007-07-21 18:54 ` David Miller
2007-07-21 23:10 ` Rusty Russell
2007-07-22 1:59 ` David Miller
2007-07-22 2:39 ` Rusty Russell
2007-07-22 3:54 ` David Miller
2007-07-22 7:18 ` David Miller
2007-07-22 7:36 ` David Miller
2007-07-22 7:51 ` Rusty Russell
2007-07-22 8:24 ` David Miller
2007-07-21 13:26 ` Andi Kleen
2007-07-23 9:58 ` Stephen Hemminger
2007-07-23 17:06 ` Andi Kleen
2007-07-23 21:14 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185002071.6344.21.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).