Re: [PATCH]: Resurrect napi_poll patch.

[Rusty Russell <rusty@rustcorp.com.au>]

On Sat, 2007-07-21 at 00:42 -0700, David Miller wrote:
> From: Rusty Russell <rusty@rustcorp.com.au>
> Date: Sat, 21 Jul 2007 17:14:31 +1000
> 
> > 	This looks good!  It might be nice though to go further and remove the
> > internal napi_struct.  It's kind of a wart for multi-queue drivers which
> > are going to have their own array (or whatever).
> 
> I guess you're suggesting to pass in a "void *" cookie instead of the
> napi_struct?  You'd need to pass in a slot number or similar as well
> with that kind of idea, and then it starts to push the limits or
> worthwhileness.

No, I was just thinking that drivers will put the napi_struct in their
driver-specific struct (eg. struct e1000_adapter *adapter =
container_of(container_of(napi, struct e1000_adapter, napi);).  

Multi-queue drivers will have no use for a napi_struct in net_device,
right?  They'll need some wrapper "my_queue" structure containing the
napi_struct anyway.

Hope that clarifies,
Rusty.