From: Rusty Russell <rusty@rustcorp.com.au>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org,
jgarzik@pobox.com
Subject: Re: [PATCH]: Resurrect napi_poll patch.
Date: Sun, 22 Jul 2007 09:10:23 +1000 [thread overview]
Message-ID: <1185059423.6344.53.camel@localhost.localdomain> (raw)
In-Reply-To: <20070721.115428.48807536.davem@davemloft.net>
On Sat, 2007-07-21 at 11:54 -0700, David Miller wrote:
> From: Rusty Russell <rusty@rustcorp.com.au>
> Date: Sat, 21 Jul 2007 18:00:11 +1000
>
> > No, I was just thinking that drivers will put the napi_struct in their
> > driver-specific struct (eg. struct e1000_adapter *adapter =
> > container_of(container_of(napi, struct e1000_adapter, napi);).
>
> That works.
>
> > Multi-queue drivers will have no use for a napi_struct in net_device,
> > right? They'll need some wrapper "my_queue" structure containing the
> > napi_struct anyway.
>
> Sure, we can eliminate the napi_struct in struct net_device
> eventually.
>
> But then again, like the statistics, if it's convenient to
> just use the in-net_device one then why not :)
Because *every* single driver can use the in-net_device stats.
In five years' time, the "napi_struct for simple drivers" in net_device
will look confusing. Since your change touches all NAPI drivers anyway,
it'd be nice to go straight to "everyone allocates their own NAPI
struct" in one jump.
Cheers,
Rusty.
next prev parent reply other threads:[~2007-07-21 23:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 5:31 [PATCH]: Resurrect napi_poll patch David Miller
2007-07-21 5:46 ` Patrick McHardy
2007-07-21 6:00 ` David Miller
2007-07-21 7:14 ` Rusty Russell
2007-07-21 7:42 ` David Miller
2007-07-21 8:00 ` Rusty Russell
2007-07-21 18:54 ` David Miller
2007-07-21 23:10 ` Rusty Russell [this message]
2007-07-22 1:59 ` David Miller
2007-07-22 2:39 ` Rusty Russell
2007-07-22 3:54 ` David Miller
2007-07-22 7:18 ` David Miller
2007-07-22 7:36 ` David Miller
2007-07-22 7:51 ` Rusty Russell
2007-07-22 8:24 ` David Miller
2007-07-21 13:26 ` Andi Kleen
2007-07-23 9:58 ` Stephen Hemminger
2007-07-23 17:06 ` Andi Kleen
2007-07-23 21:14 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185059423.6344.53.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).