netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org,
	jgarzik@pobox.com, hadi@cyberus.ca
Subject: Re: [PATCH RFX]: napi_struct V3
Date: Tue, 24 Jul 2007 16:21:43 +1000	[thread overview]
Message-ID: <1185258104.1803.223.camel@localhost.localdomain> (raw)
In-Reply-To: <20070723.224707.30179585.davem@davemloft.net>

On Mon, 2007-07-23 at 22:47 -0700, David Miller wrote:
> I don't think it's wise to implement this over and over again in each
> driver, since we already know at least a handfull of drivers will use
> this.

Yep.  Alternative is a napi_struct_with_restart, but I don't think it's
worth the few-byte savings per queue.

> Any objections?

On the contrary, this looks good.

Thanks!
Rusty.


  reply	other threads:[~2007-07-24  6:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24  4:07 [PATCH RFX]: napi_struct V3 David Miller
2007-07-24  4:47 ` Rusty Russell
2007-07-24  5:47   ` David Miller
2007-07-24  6:21     ` Rusty Russell [this message]
2007-07-25  0:45       ` David Miller
2007-07-25  1:15         ` Rusty Russell
2007-07-25  1:47           ` David Miller
2007-07-25  2:33             ` Rusty Russell
2007-07-25  4:29               ` David Miller
2007-07-25  5:09                 ` Rusty Russell
2007-07-25  5:12                   ` David Miller
2007-07-25  5:10             ` David Miller
2007-07-24  7:12 ` Francois Romieu
2007-07-24  7:33   ` Jeff Garzik
2007-07-24  7:35   ` David Miller
2007-07-28 15:21 ` Roland Dreier
2007-07-29  5:30   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185258104.1803.223.camel@localhost.localdomain \
    --to=rusty@rustcorp.com.au \
    --cc=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).