From: jamal <hadi@cyberus.ca>
To: David Miller <davem@davemloft.net>
Cc: Ben Greear <greearb@candelatech.com>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, Matt Carlson <mcarlson@broadcom.com>
Subject: RFC: on [ab]use of skb->cb by VLAN code
Date: Mon, 30 Jul 2007 20:59:16 -0400 [thread overview]
Message-ID: <1185843556.5162.8.camel@localhost> (raw)
I was going to forget this, but its been playing in the back of my head
and wont go away....
Matt Carlson recently (while fixing the tg3 driver in my batching
patches) pointed to me that skb->cb[] was being used to pass around vlan
data.
This seems like a bad use since there can be a lot of things between
a real hardware driver and something that sets a vlan tag (qdiscs come
to mind).
Creating a new skb field be the reasonable thing to do here but i know
that we are trying to avoid adding new fields. Thoughts?
cheers,
jamal
next reply other threads:[~2007-07-31 0:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 0:59 jamal [this message]
2007-07-31 1:33 ` RFC: on [ab]use of skb->cb by VLAN code David Miller
2007-07-31 2:02 ` jamal
2007-07-31 2:06 ` David Miller
2007-07-31 4:30 ` Ben Greear
2007-07-31 5:18 ` David Miller
2007-07-31 5:33 ` Ben Greear
2007-07-31 16:56 ` Rick Jones
2007-07-31 17:50 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185843556.5162.8.camel@localhost \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=kaber@trash.net \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).