From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: Robert.Olsson@data.slu.se, netdev@vger.kernel.org
Subject: Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info
Date: Tue, 31 Jul 2007 16:48:06 -0700 [thread overview]
Message-ID: <1185925686.14777.22.camel@localhost> (raw)
In-Reply-To: <20070730.160540.48528135.davem@davemloft.net>
On Mon, 2007-07-30 at 16:05 -0700, David Miller wrote:
> I still don't know about this patch. Instead of the simple
> transformation:
>
> - printk(foo);
> + printk(KERN_INFO foo);
>
> we get this new macro, and the lines changes to use that macro.
Actually, I agree.
Many local macros could be eliminated that define
printk(<level> prefix)
I'd like to see macros added to kernel.h for:
pr_err
pr_notice
pr_warn
pr_alert
pr_crit
pr_emerge
and convert tree-wide all the single-line
printk(KERN_<level> [prefix] fmt "\n", args...)
calls to the equivalent pr_<level> calls.
That would leave the multi-line printk(<level>...) calls
to be sorted out so these messages might no longer be
interleaved by multiple cpus/threads.
next prev parent reply other threads:[~2007-07-31 23:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 22:14 [PATCH] pktgen - define and use pktgen_dbg,err,warn,info Joe Perches
2007-07-18 22:49 ` David Miller
2007-07-18 23:21 ` Joe Perches
2007-07-30 23:05 ` David Miller
2007-07-31 23:48 ` Joe Perches [this message]
2007-08-01 1:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185925686.14777.22.camel@localhost \
--to=joe@perches.com \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).