From: jamal <hadi@cyberus.ca>
To: Andi Kleen <andi@firstfloor.org>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [RFC] IP_RECVERRC
Date: Fri, 10 Aug 2007 10:30:12 -0400 [thread overview]
Message-ID: <1186756212.5163.4.camel@localhost> (raw)
In-Reply-To: <20070810140214.GA10331@one.firstfloor.org>
On Fri, 2007-10-08 at 16:02 +0200, Andi Kleen wrote:
> On Fri, Aug 10, 2007 at 09:35:12AM -0400, jamal wrote:
>
> Affected in what way?
>
They dont get errors back and they just keep sending even in the
presence of errors - take a look at ip_push_pending_frames. I have been
struggling initially to unconditionally mod that part, but it may break
certain apps expectations.
> > If you set that option though you end up getting all these skbs back
>
> IP_RECVERR just delivers ICMPs. Do you mean those with "all these skbs" ?
yes - sorry thats what i meant; the app has to do a recvmsg to grab them
> > to the app which i see as unnecessary work if i am uninterested. I would
> > like to not do a recvmsg to find out what those messages are - rather
> > just receiving any errors back.
> > My proposal is to add another option which is mutually exclusive with
> > IP_RECVERR that allows for errors only.
>
> What ICMPs do you not want?
All.
cheers,
jamal
next prev parent reply other threads:[~2007-08-10 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 13:35 [RFC] IP_RECVERRC jamal
2007-08-10 14:02 ` Andi Kleen
2007-08-10 14:30 ` jamal [this message]
2007-08-10 16:26 ` Andi Kleen
2007-08-11 19:27 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186756212.5163.4.camel@localhost \
--to=hadi@cyberus.ca \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).