Re: set_multicast_list vs. set_rx_mode

Patrick McHardy
2007-08-15T12:34:28Z

Johannes Berg wrote:
> Is it intentional that in the case where set_rx_mode is assigned, you
> still need to assign set_multicast_list even if it won't ever be called
> as a flag for SIOCADDMULTI?
>
> I was thinking of converting the wireless code to use set_rx_mode and
> assign set_multicast_list only if the underlying hardware supports
> multicast filtering, and it seems that is well-supported, but it does
> seem a bit weird that set_multicast_list degrades to a flag.

Indeed, I missed that. It should check for !dev->set_multicast_list &&
!dev->set_rx_mode before returning -EINVAL.