From: Johannes Berg <johannes@sipsolutions.net>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org
Subject: Re: set_multicast_list vs. set_rx_mode
Date: Wed, 15 Aug 2007 14:44:26 +0200 [thread overview]
Message-ID: <1187181866.3998.46.camel@johannes.berg> (raw)
In-Reply-To: <46C2F2B5.60803@trash.net>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Wed, 2007-08-15 at 14:33 +0200, Patrick McHardy wrote:
> Johannes Berg wrote:
> > Is it intentional that in the case where set_rx_mode is assigned, you
> > still need to assign set_multicast_list even if it won't ever be called
> > as a flag for SIOCADDMULTI?
> >
> > I was thinking of converting the wireless code to use set_rx_mode and
> > assign set_multicast_list only if the underlying hardware supports
> > multicast filtering, and it seems that is well-supported, but it does
> > seem a bit weird that set_multicast_list degrades to a flag.
>
>
> Indeed, I missed that. It should check for !dev->set_multicast_list &&
> !dev->set_rx_mode before returning -EINVAL.
Ok. Want me to send a patch?
And then the expected behaviour is that set_rx_mode will set
IFF_ALLMULTI if it can't honour the list, right?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-08-15 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 12:33 set_multicast_list vs. set_rx_mode Johannes Berg
2007-08-15 12:33 ` Patrick McHardy
2007-08-15 12:44 ` Johannes Berg [this message]
2007-08-15 12:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187181866.3998.46.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox