From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: set_multicast_list vs. set_rx_mode Date: Wed, 15 Aug 2007 14:55:33 +0200 Message-ID: <1187182533.3998.49.camel@johannes.berg> References: <1187181208.3998.44.camel@johannes.berg> <46C2F2B5.60803@trash.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-yIzunHlD6Wau9eJXrSVD" Cc: netdev@vger.kernel.org To: Patrick McHardy Return-path: Received: from crystal.sipsolutions.net ([195.210.38.204]:58789 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752783AbXHOMwy (ORCPT ); Wed, 15 Aug 2007 08:52:54 -0400 In-Reply-To: <46C2F2B5.60803@trash.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org --=-yIzunHlD6Wau9eJXrSVD Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2007-08-15 at 14:33 +0200, Patrick McHardy wrote: > Johannes Berg wrote: > > Is it intentional that in the case where set_rx_mode is assigned, you > > still need to assign set_multicast_list even if it won't ever be called > > as a flag for SIOCADDMULTI? > >=20 > > I was thinking of converting the wireless code to use set_rx_mode and > > assign set_multicast_list only if the underlying hardware supports > > multicast filtering, and it seems that is well-supported, but it does > > seem a bit weird that set_multicast_list degrades to a flag. >=20 >=20 > Indeed, I missed that. It should check for !dev->set_multicast_list && > !dev->set_rx_mode before returning -EINVAL. Hmm. We don't really support multiple unicast addresses so I should probably not use set_rx_mode. What is the meaning of dev->change_rx_flags? It seems to be called with IFF_ALLMULTI but if it is assigned and set_multicast_list is not then you also cannot add multicast addresses via SIOCADDMULTI. johannes --=-yIzunHlD6Wau9eJXrSVD Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Comment: Johannes Berg (powerbook) iD8DBQBGwvfF/ETPhpq3jKURArW6AJ4jeudCm9AUBbs242cJsd4eaauLpwCfWd8l 4bDtAWdhSuN3HlGobazMREA= =HHUm -----END PGP SIGNATURE----- --=-yIzunHlD6Wau9eJXrSVD--