From: Johannes Berg <johannes@sipsolutions.net>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>
Subject: Re: net-2.6.24 build broken (allyesconfig)
Date: Mon, 27 Aug 2007 14:52:59 +0200 [thread overview]
Message-ID: <1188219179.7837.15.camel@johannes.berg> (raw)
In-Reply-To: <Pine.LNX.4.64.0708271522400.16245@kivilampi-30.cs.helsinki.fi>
On Mon, 2007-08-27 at 15:32 +0300, Ilpo Järvinen wrote:
> drivers/net/82596.c:1618:1: error: unterminated argument list invoking
> macro "DEB"
> Hmm, I would guess that "[NET]: Introduce MAC_FMT/MAC_ARG" broken it,
> though didn't verify it.
>
> The fix is left as an exercise of the reader (i.e., the solution wasn't
> too obvious for me :-) )...
Yup, my fault, sorry about that.
From: Johannes Berg <johannes@sipsolutions.net>
Subject: fix MAC_FMT/MAC_ARG in 82596.c
This fixes a typo in commit f98d4ca4986fec.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/82596.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- netdev-2.6.orig/drivers/net/82596.c 2007-08-27 14:48:19.674646075 +0200
+++ netdev-2.6/drivers/net/82596.c 2007-08-27 14:48:21.674646075 +0200
@@ -1562,7 +1562,7 @@ static void set_multicast_list(struct ne
memcpy(cp, dmi->dmi_addr, 6);
if (i596_debug > 1)
DEB(DEB_MULTI,printk(KERN_INFO "%s: Adding address " MAC_FMT "\n",
- dev->name, MAC_ARG(cp));
+ dev->name, MAC_ARG(cp)));
}
i596_add_cmd(dev, &cmd->cmd);
}
prev parent reply other threads:[~2007-08-27 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 12:32 net-2.6.24 build broken (allyesconfig) Ilpo Järvinen
2007-08-27 12:48 ` [NET] 82596: Add missing parenthesis Thomas Graf
2007-08-27 12:52 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188219179.7837.15.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).