From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
Cc: Satyam Sharma <satyam-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Florian Lohoff <flo-BCn6idZOOBwdnm+yROfE0A@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Michal Piotrowski
<michal.k.k.piotrowski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
ipw3945-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
yi.zhu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170
Date: Thu, 06 Sep 2007 17:19:55 +0200 [thread overview]
Message-ID: <1189091995.28781.99.camel@johannes.berg> (raw)
In-Reply-To: <20070906082301.GB21929-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
On Thu, 2007-09-06 at 16:23 +0800, Herbert Xu wrote:
> On Thu, Sep 06, 2007 at 10:32:33AM +0530, Satyam Sharma wrote:
> >
> > > > [ 382.529041] [<c02c8abc>] dev_close+0x24/0x67
> > > > [ 382.529052] [<e01f402b>] ieee80211_master_stop+0x4a/0x6d [mac80211]
>
> This is where the bug is. You cannot call dev_close from an
> atomic context as i33380211_master_stop does it within spin
> locks.
Oh btw. Can we stick a might_sleep() into dev_close() *before* the test
whether the device is up? That way, we'd have seen the bug, but
apparently nobody before Florian ever did a 'ip link set wmaster0 down'
while the other interfaces were still open.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-09-06 15:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070902184439.GA14306@paradigm.rfc822.org>
2007-09-02 23:59 ` BUG: scheduling while atomic: ifconfig/0x00000002/4170 Michal Piotrowski
[not found] ` <6bffcb0e0709021659o3856cd06gabc054c949a84397-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-09-06 5:02 ` Satyam Sharma
[not found] ` <alpine.LFD.0.999.0709060923340.26804-cF9xTIDbLT5E1qDFBaZ7QYsk13R+tSIrn9A1Ff6Mc9Q@public.gmane.org>
2007-09-06 8:20 ` Herbert Xu
2007-09-06 8:23 ` Herbert Xu
[not found] ` <20070906082301.GB21929-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2007-09-06 8:41 ` Satyam Sharma
2007-09-06 8:38 ` Florian Lohoff
2007-09-06 12:09 ` Johannes Berg
[not found] ` <1189080575.28781.65.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-09-06 12:36 ` Herbert Xu
[not found] ` <E1ITGb2-0006Be-00-XQvu0L+U/CjiRBuR/1fSEKKkPtS2pBon@public.gmane.org>
2007-09-06 12:44 ` Johannes Berg
2007-09-06 13:36 ` Johannes Berg
2007-09-06 15:46 ` Paul E. McKenney
[not found] ` <20070906154612.GD8030-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2007-09-07 13:27 ` Johannes Berg
2007-09-07 14:25 ` Paul E. McKenney
[not found] ` <20070907142538.GC8864-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2007-09-07 14:30 ` Johannes Berg
2007-09-07 14:35 ` Johannes Berg
2007-09-07 14:38 ` [RFC] mac80211: fix virtual interface locking Johannes Berg
2007-09-07 16:01 ` BUG: scheduling while atomic: ifconfig/0x00000002/4170 Michael Buesch
[not found] ` <200709071801.34909.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-09-07 19:17 ` Johannes Berg
2007-09-06 12:52 ` Satyam Sharma
[not found] ` <alpine.LFD.0.999.0709061818270.3781-cF9xTIDbLT5E1qDFBaZ7QYsk13R+tSIrn9A1Ff6Mc9Q@public.gmane.org>
2007-09-06 12:46 ` Johannes Berg
2007-09-06 15:19 ` Johannes Berg [this message]
2007-09-12 12:34 ` David Miller
2007-09-13 7:16 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189091995.28781.99.camel@johannes.berg \
--to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
--cc=flo-BCn6idZOOBwdnm+yROfE0A@public.gmane.org \
--cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
--cc=ipw3945-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michal.k.k.piotrowski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=satyam-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=yi.zhu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox