From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Chan" Subject: Re: [TG3]: Workaround MSI bug on 5714/5780. Date: Thu, 06 Sep 2007 12:05:30 -0700 Message-ID: <1189105530.4852.8.camel@dell> References: <1189022828.4960.2.camel@dell> <20070906.040235.71121480.davem@davemloft.net> <20070906134508.GA10317@gospo.rdu.redhat.com> <20070906.073423.74747465.davem@davemloft.net> <20070906154123.GC10317@gospo.rdu.redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "David Miller" , "netdev" To: "Andy Gospodarek" Return-path: Received: from mms2.broadcom.com ([216.31.210.18]:4355 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755095AbXIFSIS (ORCPT ); Thu, 6 Sep 2007 14:08:18 -0400 In-Reply-To: <20070906154123.GC10317@gospo.rdu.redhat.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 2007-09-06 at 11:41 -0400, Andy Gospodarek wrote: > On Thu, Sep 06, 2007 at 07:34:23AM -0700, David Miller wrote: > > From: Andy Gospodarek > > Date: Thu, 6 Sep 2007 09:45:16 -0400 > > > > > Is is really necessary to get rid of the HT1000 patch? > > > > Yes, absolutely and without a single doubt. > > > > > commit e3008dedff4bdc96a5f67224cd3d8d12237082a0 > > > Author: Andy Gospodarek > > > Date: Thu May 10 22:58:57 2007 -0700 > > > > > > PCI: disable MSI by default on systems with Serverworks HT1000 chips > > > > > > This patch was designed to address tg3 and bnx2 messages printed on > > > systems with HT1000 chips IIRC. Are we going back to those messages on > > > bnx2 or is there a workaround in that driver needed too? > > > > Every report of that problem is with tg3 chips afflicted by this > > INTX bug which is now worked around properly. > > > > Not according to this: > > https://bugzilla.redhat.com/show_bug.cgi?id=227657 > > Which was precisely why I chose to look at it as a chipset issue. The HT1000 bridge may very well have an MSI issue. I'm checking with ServerWorks and I will do some testing to confirm. If confirmed, we can disable MSI behind the HT1000 bridge instead of globally. The 5714 issue is not caused by the HT1000 as it is not behind the HT1000. > > > Even my Niagara T1000 box was hit by this absolutely stupid and > > wrong MSI quirk, which is how I found this problem to begin with. > > > > I'm reverting it. > > > > If that's the case, do we need to consider that some of the bnx2 > hardware (like in this case the 5706) needs a similar workaround? 5706 doesn't have this same MSI problem as the 5714.