netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Mandeep Singh Baines <mandeep.baines@gmail.com>
Cc: James Chapman <jchapman@katalix.com>,
	netdev@vger.kernel.org, davem@davemloft.net, jeff@garzik.org,
	ossthema@de.ibm.com, Stephen Hemminger <shemminger@osdl.org>
Subject: Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates
Date: Mon, 10 Sep 2007 08:12:52 -0400	[thread overview]
Message-ID: <1189426372.4271.19.camel@localhost> (raw)
In-Reply-To: <20070908164222.GB3765@ludhiana>

On Sat, 2007-08-09 at 09:42 -0700, Mandeep Singh Baines wrote:

> Reading the "interrupt pending" register would require an MMIO read.
> MMIO reads are very expensive. In some systems the latency of an MMIO
> read can be 1000x that of an L1 cache access.

Indeed.

> However, work_done() doesn't have to be inefficient. For newer
> devices you can implement work_done() without an MMIO read by polling
> the next ring entry status in memory or some other mechanism. Since
> PCI is coherent, acceses to this memory location could be cached
> after the first miss. For architectures where PCI is not coherent you'd 
> have to go to memory for every poll. So for these architectures has_work()
> will be moderately expensive (memory access) even when has_work() does
> not require an MMIO read. This might affect home routers: not sure if MIPS or
> ARM have coherent PCI.

I think the effect would be clearly experimentally observable in smaller
devices e.g the Geode you seem to be experimenting on.
One other suggestion i made in the paper is to something along the lines
of cached_irq_mask for the i8259

cheers,
jamal


  parent reply	other threads:[~2007-09-10 12:13 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-06 14:16 RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates James Chapman
2007-09-06 14:37 ` Stephen Hemminger
2007-09-06 15:30   ` James Chapman
2007-09-06 15:37     ` Stephen Hemminger
2007-09-06 16:07       ` James Chapman
2007-09-06 23:06 ` jamal
2007-09-07  9:31   ` James Chapman
2007-09-07 13:22     ` jamal
2007-09-10  9:20       ` James Chapman
2007-09-10 12:27         ` jamal
2007-09-12  7:04       ` Bill Fink
2007-09-12 12:12         ` jamal
2007-09-12 13:50           ` James Chapman
2007-09-12 14:02             ` Stephen Hemminger
2007-09-12 16:26               ` James Chapman
2007-09-12 16:47               ` Mandeep Baines
2007-09-13  6:57                 ` David Miller
2007-09-14 13:14             ` jamal
2007-09-07 21:20     ` Jason Lunz
2007-09-10  9:25       ` James Chapman
2007-09-07  3:55 ` Mandeep Singh Baines
2007-09-07  9:38   ` James Chapman
2007-09-08 16:42     ` Mandeep Singh Baines
2007-09-10  9:33       ` James Chapman
2007-09-10 12:12       ` jamal [this message]
2007-09-08 16:32 ` Andi Kleen
2007-09-10  9:25   ` James Chapman
2007-09-12 15:12 ` David Miller
2007-09-12 16:39   ` James Chapman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1189426372.4271.19.camel@localhost \
    --to=hadi@cyberus.ca \
    --cc=davem@davemloft.net \
    --cc=jchapman@katalix.com \
    --cc=jeff@garzik.org \
    --cc=mandeep.baines@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=ossthema@de.ibm.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).