netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Medve Emilian-EMMEDVE1 <Emilian.Medve@freescale.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	i2c@lm-sensors.org, linux-omap-open-source@linux.omap.com
Subject: RE: [PATCH v3] Make the pr_*() family of macros in kernel.h complete
Date: Wed, 12 Sep 2007 22:11:14 -0700	[thread overview]
Message-ID: <1189660274.19708.125.camel@localhost> (raw)
In-Reply-To: <598D5675D34BE349929AF5EDE9B03E27014F9FDA@az33exm24.fsl.freescale.net>

On Wed, 2007-09-12 at 11:44 -0700, Medve Emilian-EMMEDVE1 wrote:
> First, this patch doesn't have the trailing "\n" problem that one had.

I expect all the kernel logging functions to be
overhauled eventually.

I'd prefer a mechanism that somehow supports
identifying complete messages.  I think the new
pr_<level> functions are not particularly useful
without a mechanism to avoid or identify multiple
processors or threads interleaving partial in-progress
multiple statement messages.

I've got a very large patch series that converts _all_
the current single line messages that use KERN_<level>
to pr_<level> and identifies, prefixes and postfixes
the rest of the multiple source line messages.

At some point, sooner or later, the logging functions
will be improved.  Apparently, more likely later.

cheers, Joe


  reply	other threads:[~2007-09-13  5:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12 16:39 [PATCH v3] Make the pr_*() family of macros in kernel.h complete Emil Medve
2007-09-12 18:04 ` Jan Engelhardt
2007-09-12 18:44   ` Medve Emilian-EMMEDVE1
2007-09-13  5:11     ` Joe Perches [this message]
2007-09-13 14:32       ` [PATCH v3] Make the pr_*() family of macros in kernel.hcomplete Medve Emilian-EMMEDVE1
2007-09-14 13:27 ` [PATCH v3] Make the pr_*() family of macros in kernel.h complete Medve Emilian-EMMEDVE1
2007-09-14 16:41   ` Satyam Sharma
2007-09-14 17:13     ` Randy Dunlap
2007-09-14 20:18   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1189660274.19708.125.camel@localhost \
    --to=joe@perches.com \
    --cc=Emilian.Medve@freescale.com \
    --cc=i2c@lm-sensors.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).