netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Chan" <mchan@broadcom.com>
To: "Ingo Oeser" <netdev@axxeo.de>
Cc: "Lucas Nussbaum" <lucas.nussbaum@imag.fr>,
	"netdev" <netdev@vger.kernel.org>
Subject: Re: [BUG] tg3 cannot do PXE (loses MAC address) after soft reboot
Date: Fri, 14 Sep 2007 11:52:22 -0700	[thread overview]
Message-ID: <1189795942.9540.155.camel@dell> (raw)
In-Reply-To: <200709141014.20635.netdev@axxeo.de>

On Fri, 2007-09-14 at 10:14 +0200, Ingo Oeser wrote:
> Michael Chan schrieb:
> > On Thu, 2007-09-13 at 21:28 +0200, Lucas Nussbaum wrote:
> > > Erm, Wouldn't it be possible to print a warning when the driver loads,
> > > saying that the firmware is outdated ?
> > 
> > It's possible, but would require the driver to parse the version string.
> > The driver currently reports the version string for information and for
> > the human to parse it.
> 
> Yes, but most humans don't know all valid firmware versions of their 
> components.
> 
> Is it enough to parse the first number in the firmware via simple_strtoul()?

No, it's not.  We need to check the number after the '.' and possibly an
alphabet at the end as well.  Worse yet, the version may be different
for different chips.

We'll see if we can come up with a simple way to detect the problem.



  reply	other threads:[~2007-09-14 17:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-13  8:39 [BUG] tg3 cannot do PXE (loses MAC address) after soft reboot Lucas Nussbaum
2007-09-13 15:15 ` Michael Chan
2007-09-13 15:41   ` Lucas Nussbaum
2007-09-13 18:05     ` Michael Chan
2007-09-13 19:28       ` Lucas Nussbaum
2007-09-13 20:47         ` Michael Chan
2007-09-14  8:14           ` Ingo Oeser
2007-09-14 18:52             ` Michael Chan [this message]
2007-09-17 11:29               ` Ingo Oeser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1189795942.9540.155.camel@dell \
    --to=mchan@broadcom.com \
    --cc=lucas.nussbaum@imag.fr \
    --cc=netdev@axxeo.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).