From: jamal <hadi@cyberus.ca>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH|[NET]: migrate HARD_TX_LOCK to header file
Date: Sun, 16 Sep 2007 16:28:41 -0400 [thread overview]
Message-ID: <1189974522.4230.3.camel@localhost> (raw)
In-Reply-To: <20070916.122842.59467739.davem@davemloft.net>
On Sun, 2007-16-09 at 12:28 -0700, David Miller wrote:
> The only reason the cpu argument is superfluous is because
> we don't provide a way to pass it on down to netif_tx_lock().
>
> So instead netif_tx_lock() recomputes that value in this case which is
> extra unnecessary work.
>
> I would instead suggest ..
sounds much better - will resend after a simple test.
cheers,
jamal
next prev parent reply other threads:[~2007-09-16 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-16 15:48 [PATCH|[NET]: migrate HARD_TX_LOCK to header file jamal
2007-09-16 19:28 ` David Miller
2007-09-16 20:28 ` jamal [this message]
2007-09-16 20:57 ` jamal
2007-09-16 21:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189974522.4230.3.camel@localhost \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).