From: Bryan Wu <bryan.wu@analog.com>
To: Robin Getz <rgetz@blackfin.uclinux.org>
Cc: bryan.wu@analog.com, jeff@garzik.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] Blackfin EMAC driver: Add phyabstraction layer supporting in bfin_emac driver
Date: Mon, 17 Sep 2007 11:11:44 +0800 [thread overview]
Message-ID: <1189998704.7800.1.camel@roc-desktop> (raw)
In-Reply-To: <200709162251.01558.rgetz@blackfin.uclinux.org>
On Sun, 2007-09-16 at 22:51 -0400, Robin Getz wrote:
> On Sat 15 Sep 2007 22:57, Bryan Wu pondered:
> >
> > - add MDIO functions and register mdio bus
> > - add phy abstraction layer (PAL) functions and use PAL API
> > - test on STAMP537 board
>
> Today, the Kconfig for the Blackfin just includes:
>
> > config BFIN_MAC
> > tristate "Blackfin 536/537 on-chip mac support"
> > depends on NET_ETHERNET && (BF537 || BF536) && (!BF537_PORT_H)
> > select CRC32
> > select BFIN_MAC_USE_L1 if DMA_UNCACHED_NONE
> > help
> > This is the driver for blackfin on-chip mac device. Say Y if you
> > want it compiled into the kernel. This driver is also available as a module
> > ( = code which can be inserted in and removed from the running kernel
> > whenever you want). The module will be called bfin_mac.
>
> Since you are adding requirement for the PHYLIB with this patch, should there
> be a select for that?
>
> -Robin
OK, I will send a patch for this update, since some people failed to
compile the kernel without select the PHYLIB.
Thanks
-Bryan Wu
next prev parent reply other threads:[~2007-09-17 3:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-16 2:57 [PATCH 3/3] Blackfin EMAC driver: Add phy abstraction layer supporting in bfin_emac driver Bryan Wu
2007-09-17 2:51 ` [PATCH 3/3] Blackfin EMAC driver: Add phyabstraction " Robin Getz
2007-09-17 3:11 ` Bryan Wu [this message]
2007-09-17 3:20 ` [PATCH] Blackfin EMAC driver: add a select for the PHYLIB of this driver Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189998704.7800.1.camel@roc-desktop \
--to=bryan.wu@analog.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rgetz@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).