netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhu Yi <yi.zhu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: "John W. Linville"
	<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
	jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Please pull 'iwlwifi' branch of wireless-2.6
Date: Fri, 21 Sep 2007 09:20:30 +0800	[thread overview]
Message-ID: <1190337630.5718.136.camel@debian.sh.intel.com> (raw)
In-Reply-To: <20070919101326.GA32432-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>

On Wed, 2007-09-19 at 11:13 +0100, Christoph Hellwig wrote:
> it really needs to be moved into a directory of it's own.

It used to be... John?

> The useless per-file CFLAGS need to go most places can trivially
> be made unconditional anyway.

OK.

> The depends on m for CONFIG_IWL4965 and CONFIG_IWL3945 needs to go,
> we don't put drivers int that need to be modular. 

Since we splited the code base for 3945 and 4965 by a simple "fork" of
file iwl-base.c, some non-static functions names remain the same. Make
the two drivers build into vmlinux at the same time will cause conflict.
So to make them depend on m is a current workaround for .24. We will
abstract a common iwl-core.ko and make driver specific iwl3945.ko and
iwl4965.ko depend on it in .25 time frame.

Thanks,
-yi

  parent reply	other threads:[~2007-09-21  1:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-18 18:50 Please pull 'iwlwifi' branch of wireless-2.6 John W. Linville
     [not found] ` <20070918185040.GF4940-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-09-18 19:22   ` David Miller
     [not found]     ` <20070918.122258.82101397.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2007-09-19 13:28       ` Jeff Garzik
     [not found]         ` <46F12414.8000900-o2qLIJkoznsdnm+yROfE0A@public.gmane.org>
2007-09-19 14:57           ` John W. Linville
2007-09-19 10:13 ` Christoph Hellwig
     [not found]   ` <20070919101326.GA32432-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2007-09-21  1:20     ` Zhu Yi [this message]
2007-09-21  1:34       ` John W. Linville
2007-09-26  2:31         ` David Miller
2007-09-21  8:05       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190337630.5718.136.camel@debian.sh.intel.com \
    --to=yi.zhu-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).