From: jamal <hadi@cyberus.ca>
To: Chris Leech <chris.leech@gmail.com>
Cc: Ben Greear <greearb@candelatech.com>,
Emil Micek <emil.micek@tkrjasek.cz>,
"auke-jan.h.kok@intel.com" <auke-jan.h.kok@intel.com>,
netdev mailing list <netdev@vger.kernel.org>,
Jesse <jesse.brandeburg@intel.com>
Subject: Re: change the way e1000 is handling short VLAN frames
Date: Fri, 21 Sep 2007 17:36:25 -0400 [thread overview]
Message-ID: <1190410585.4231.46.camel@localhost> (raw)
In-Reply-To: <41b516cb0709211427s45cdd3b0pa0bb76d114d5f041@mail.gmail.com>
On Fri, 2007-21-09 at 14:27 -0700, Chris Leech wrote:
>
> Inserting the VLAN tag in software will not change the behavior in the
> way you want anyway, short frames will still be padded to 64 bytes.
> You'd have to do short packet padding in software to 68 bytes. Or do
> software padding to 64 bytes and let the hardware insert the VLAN tag
> after.
I like the second one because it could be done totaly in the driver and
would resolve the problem IMO. All we need after is an ethtool knob to
select between 64B or 68B txmit.
cheers,
jamal
next prev parent reply other threads:[~2007-09-21 21:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 7:31 change the way e1000 is handling short VLAN frames Emil Micek
2007-09-21 11:59 ` jamal
2007-09-21 12:50 ` Emil Micek
2007-09-21 13:37 ` jamal
2007-09-21 13:46 ` jamal
2007-09-21 14:27 ` Francesco Fondelli
2007-09-21 15:43 ` Ben Greear
2007-09-21 21:12 ` jamal
2007-09-21 21:18 ` Ben Greear
2007-09-21 21:21 ` Kok, Auke
2007-09-21 21:29 ` jamal
2007-09-21 21:34 ` Kok, Auke
2007-09-21 21:43 ` jamal
2007-09-21 22:02 ` Chris Leech
2007-09-24 8:40 ` Emil Micek
2007-09-21 21:27 ` Chris Leech
2007-09-21 21:36 ` jamal [this message]
2007-09-21 17:05 ` Brandeburg, Jesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190410585.4231.46.camel@localhost \
--to=hadi@cyberus.ca \
--cc=auke-jan.h.kok@intel.com \
--cc=chris.leech@gmail.com \
--cc=emil.micek@tkrjasek.cz \
--cc=greearb@candelatech.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).