From: "Michael Chan" <mchan@broadcom.com>
To: "David Miller" <davem@davemloft.net>
Cc: vda.linux@googlemail.com, jeff@garzik.org,
linux-kernel@vger.kernel.org, "netdev" <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/2] bnx2: factor out gzip unpacker
Date: Fri, 21 Sep 2007 19:47:17 -0700 [thread overview]
Message-ID: <1190429237.4957.6.camel@dell> (raw)
In-Reply-To: <20070921.104912.41646795.davem@davemloft.net>
On Fri, 2007-09-21 at 10:49 -0700, David Miller wrote:
> From: Denys Vlasenko <vda.linux@googlemail.com>
> Date: Fri, 21 Sep 2007 18:03:55 +0100
>
> > Do patches look ok to you?
>
> I'm travelling so I haven't looked closely yet :-)
>
> Michael can take a look and I'll try to do so as well
> tonight.
>
I've already reviewed the earlier versions of the patch and have made
some suggestions. This latest one looks ok to me and tested ok.
I'll follow up later with another patch to remove all the zeros in other
firmware sections, and to remove the gzip headers completely.
Acked-by: Michael Chan <mchan@broadcom.com>
next prev parent reply other threads:[~2007-09-22 1:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 11:01 [PATCH 1/2] bnx2: factor out gzip unpacker Denys Vlasenko
2007-09-21 11:03 ` [PATCH 2/2] bnx2: move gzip unpacker to zlib Denys Vlasenko
2007-09-21 16:14 ` [PATCH 1/2] bnx2: factor out gzip unpacker David Miller
2007-09-21 17:03 ` Denys Vlasenko
2007-09-21 17:49 ` David Miller
2007-09-21 18:05 ` Denys Vlasenko
2007-09-21 18:36 ` Valdis.Kletnieks
2007-09-21 19:18 ` Denys Vlasenko
2007-09-21 19:32 ` Valdis.Kletnieks
2007-09-21 19:33 ` Krzysztof Oledzki
2007-09-21 22:43 ` Denys Vlasenko
2007-09-21 22:57 ` Jeff Garzik
2007-09-21 21:03 ` Alan Cox
2007-09-21 22:33 ` Jeff Garzik
2007-09-21 22:48 ` Alan Cox
2007-09-22 0:02 ` maximilian attems
2007-09-21 20:13 ` Andi Kleen
2007-09-21 20:31 ` Roland Dreier
2007-09-21 22:37 ` Denys Vlasenko
2007-09-24 17:32 ` Lennart Sorensen
2007-09-25 4:20 ` Kyle Moffett
2007-09-22 2:47 ` Michael Chan [this message]
2007-10-01 0:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190429237.4957.6.camel@dell \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).