netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Steve Wise <swise@opengridcomputing.com>
Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
	netdev@vger.kernel.org, Robert Olsson <Robert.Olsson@data.slu.se>
Subject: Re: pktgen question
Date: Sun, 23 Sep 2007 14:18:47 -0400	[thread overview]
Message-ID: <1190571527.4256.78.camel@localhost> (raw)
In-Reply-To: <46F6A887.1030301@opengridcomputing.com>

On Sun, 2007-23-09 at 12:55 -0500, Steve Wise wrote:

> Its a hack that breaks cxgb3 because cxgb3 uses the skb->cb area for 
> each skb passed down.  So cxgb3 is at fault then?  IE a driver cannot 
> use the skb->cb field if the users count is > 1?  Or maybe a driver can 
> _never_ use the cb field?

any layer can use the cb structure whichever way they wish. There are
violations, e.g:
the vlan code also uses the cb field to pass vlan details for hardware
acceleration. How does pktgen affect it though, clone() will just copy
the cb field and pktgen doesnt touch it.
In retrospect, pktgen may have to use clone - ccing Robert Olsson.

cheers,
jamal


  reply	other threads:[~2007-09-23 18:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-23 16:12 pktgen question Steve Wise
2007-09-23 17:28 ` Evgeniy Polyakov
2007-09-23 17:55   ` Steve Wise
2007-09-23 18:18     ` jamal [this message]
2007-09-24  6:30       ` Ben Greear
2007-09-24 13:54         ` Steve Wise
2007-09-24 14:39           ` Ben Greear
2007-09-24 15:00             ` Steve Wise
2007-09-24 15:37               ` Ben Greear
2007-09-24 18:02                 ` Rick Jones
2007-09-24 18:22                   ` Ben Greear
2007-10-08 21:43                     ` Steve Wise
2007-10-08 21:57                       ` Ben Greear
2007-10-08 22:22                         ` David Miller
2007-10-08 22:46                           ` Steve Wise
2007-10-08 22:54                             ` David Miller
2007-09-24 15:42           ` Robert Olsson
2007-09-24 17:40           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190571527.4256.78.camel@localhost \
    --to=hadi@cyberus.ca \
    --cc=Robert.Olsson@data.slu.se \
    --cc=johnpol@2ka.mipt.ru \
    --cc=netdev@vger.kernel.org \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).