* [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver
@ 2007-09-24 8:57 Zang Roy-r61911
2007-09-28 3:36 ` Jeff Garzik
2007-09-29 4:50 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Zang Roy-r61911 @ 2007-09-24 8:57 UTC (permalink / raw)
To: jeff; +Cc: Andrew Morton, netdev
From: Roy Zang <tie-fei.zang@freescale.com>
Clean up redundant PHY write line for ULi526x Ethernet
Driver.
Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
---
drivers/net/tulip/uli526x.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tulip/uli526x.c b/drivers/net/tulip/uli526x.c
index ca2548e..53a8e65 100644
--- a/drivers/net/tulip/uli526x.c
+++ b/drivers/net/tulip/uli526x.c
@@ -1512,7 +1512,6 @@ static void uli526x_process_mode(struct uli526x_board_info *db)
case ULI526X_100MFD: phy_reg = 0x2100; break;
}
phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
- phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
}
}
}
--
1.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver
2007-09-24 8:57 [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver Zang Roy-r61911
@ 2007-09-28 3:36 ` Jeff Garzik
2007-09-28 3:57 ` Grant Grundler
2007-09-29 4:50 ` Jeff Garzik
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2007-09-28 3:36 UTC (permalink / raw)
Cc: Zang Roy-r61911, Andrew Morton, netdev, Kyle McMartin,
Grant Grundler
Zang Roy-r61911 wrote:
> From: Roy Zang <tie-fei.zang@freescale.com>
>
> Clean up redundant PHY write line for ULi526x Ethernet
> Driver.
>
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> ---
> drivers/net/tulip/uli526x.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/tulip/uli526x.c b/drivers/net/tulip/uli526x.c
> index ca2548e..53a8e65 100644
> --- a/drivers/net/tulip/uli526x.c
> +++ b/drivers/net/tulip/uli526x.c
> @@ -1512,7 +1512,6 @@ static void uli526x_process_mode(struct uli526x_board_info *db)
> case ULI526X_100MFD: phy_reg = 0x2100; break;
> }
> phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
> - phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
Kyle and Grant, I'll queue this up, unless ya'll object...
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver
2007-09-28 3:36 ` Jeff Garzik
@ 2007-09-28 3:57 ` Grant Grundler
0 siblings, 0 replies; 4+ messages in thread
From: Grant Grundler @ 2007-09-28 3:57 UTC (permalink / raw)
To: Jeff Garzik
Cc: Zang Roy-r61911, Andrew Morton, netdev, Kyle McMartin,
Grant Grundler
On Thu, Sep 27, 2007 at 11:36:58PM -0400, Jeff Garzik wrote:
> Zang Roy-r61911 wrote:
>> From: Roy Zang <tie-fei.zang@freescale.com>
>> Clean up redundant PHY write line for ULi526x Ethernet
>> Driver.
>> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
>> ---
>> drivers/net/tulip/uli526x.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>> diff --git a/drivers/net/tulip/uli526x.c b/drivers/net/tulip/uli526x.c
>> index ca2548e..53a8e65 100644
>> --- a/drivers/net/tulip/uli526x.c
>> +++ b/drivers/net/tulip/uli526x.c
>> @@ -1512,7 +1512,6 @@ static void uli526x_process_mode(struct
>> uli526x_board_info *db)
>> case ULI526X_100MFD: phy_reg = 0x2100; break;
>> }
>> phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
>> - phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
>
> Kyle and Grant, I'll queue this up, unless ya'll object...
please do, I've already Ack'd it for akpm's tree when he sent out the
initial cc.
thanks,
grant
>
> Jeff
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver
2007-09-24 8:57 [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver Zang Roy-r61911
2007-09-28 3:36 ` Jeff Garzik
@ 2007-09-29 4:50 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-09-29 4:50 UTC (permalink / raw)
To: Zang Roy-r61911; +Cc: Andrew Morton, netdev
Zang Roy-r61911 wrote:
> From: Roy Zang <tie-fei.zang@freescale.com>
>
> Clean up redundant PHY write line for ULi526x Ethernet
> Driver.
>
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> ---
> drivers/net/tulip/uli526x.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-09-29 4:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-24 8:57 [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver Zang Roy-r61911
2007-09-28 3:36 ` Jeff Garzik
2007-09-28 3:57 ` Grant Grundler
2007-09-29 4:50 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).