netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: David Miller <davem@davemloft.net>
Cc: urs@isnogud.escape.de, shemminger@linux-foundation.org,
	netdev@vger.kernel.org, kaber@trash.net, joe@perches.com,
	oliver@hartkopp.net, oliver.hartkopp@volkswagen.de
Subject: Re: [PATCH 2/7] CAN: Add PF_CAN core module
Date: Fri, 28 Sep 2007 22:28:18 +0200	[thread overview]
Message-ID: <1191011298.18681.88.camel@chaos> (raw)
In-Reply-To: <20070928.132038.35678834.davem@davemloft.net>

On Fri, 2007-09-28 at 13:20 -0700, David Miller wrote:
> That's not true with CAN.
> 
> With this CAN stuff, any driver you write for it is intimately
> integrated into the design and architecture of the CAN subsystem.  Any
> such driver cannot stand on it's own.  Look at how these drivers can
> get into the internals.

I'm just concerned about protocols, which have been designed and
implemented long ago outside of the kernel and are going to be wrapped
with glue code to fit into the socket can implementation. That's hard to
judge.

> If this code goes in without the _GPL() exports, that's fine, but it's
> setting incorrect expectations for people who think they can write
> binary-only drivers and link to these symbols.
> 
> And it will be the CAN folks who are guilty of setting these
> false premises.  Especially after I've explicitly warned about
> it here.

Fair enough.

	tglx



  reply	other threads:[~2007-09-28 20:28 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-25 12:20 [PATCH 0/7] CAN: Add new PF_CAN protocol family, try #8 Urs Thuermann
2007-09-25 12:20 ` [PATCH 1/7] CAN: Allocate protocol numbers for PF_CAN Urs Thuermann
2007-09-25 12:20 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-09-25 12:41   ` Arnaldo Carvalho de Melo
2007-09-25 13:24     ` Urs Thuermann
2007-09-25 15:33       ` Stephen Hemminger
2007-09-25 21:00         ` Urs Thuermann
2007-09-25 21:07           ` Stephen Hemminger
2007-09-25 21:09           ` David Miller
2007-09-28 16:27             ` Thomas Gleixner
2007-09-28 20:20               ` David Miller
2007-09-28 20:28                 ` Thomas Gleixner [this message]
2007-09-25 12:20 ` [PATCH 3/7] CAN: Add raw protocol Urs Thuermann
2007-09-25 12:20 ` [PATCH 4/7] CAN: Add broadcast manager (bcm) protocol Urs Thuermann
2007-09-25 12:51   ` Arnaldo Carvalho de Melo
2007-09-25 13:26     ` Urs Thuermann
2007-09-25 12:20 ` [PATCH 5/7] CAN: Add virtual CAN netdevice driver Urs Thuermann
2007-09-25 13:26   ` YOSHIFUJI Hideaki / 吉藤英明
2007-09-25 14:00     ` Urs Thuermann
2007-09-25 14:47       ` Patrick McHardy
2007-09-25 17:55         ` Oliver Hartkopp
2007-09-25 17:53           ` Patrick McHardy
2007-09-25 19:09             ` Oliver Hartkopp
2007-09-25 12:20 ` [PATCH 6/7] CAN: Add maintainer entries Urs Thuermann
2007-09-25 12:20 ` [PATCH 7/7] CAN: Add documentation Urs Thuermann
  -- strict thread matches above, loose matches on Subject: below --
2007-11-16 15:02 [PATCH 0/7] CAN: New PF_CAN protocol family for 2.6.25, update Urs Thuermann
2007-11-16 15:02 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-11-14 12:13 [PATCH 0/7] CAN: New PF_CAN protocol family for 2.6.25 Urs Thuermann
2007-11-14 12:13 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-11-14 21:38   ` Stephen Hemminger
2007-11-15  7:40     ` Oliver Hartkopp
2007-11-15  8:04       ` Joe Perches
2007-11-15 11:51         ` Urs Thuermann
2007-11-15 12:05           ` David Miller
2007-11-15 15:11             ` Sam Ravnborg
2007-11-16 14:33             ` Urs Thuermann
2007-11-16 23:42               ` David Miller
2007-11-15 11:36     ` Urs Thuermann
2007-11-15 15:09       ` Sam Ravnborg
2007-10-05 10:49 [PATCH 0/7] CAN: Add new PF_CAN protocol family, try #10 Urs Thuermann
2007-10-05 10:49 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-10-02 13:10 [PATCH 0/7] CAN: Add new PF_CAN protocol family, try #9 Urs Thuermann
2007-10-02 13:10 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-10-02 14:38   ` Arnaldo Carvalho de Melo
2007-10-02 16:09     ` Oliver Hartkopp
2007-10-04 11:51     ` Urs Thuermann
2007-10-04 13:40       ` Arnaldo Carvalho de Melo
2007-09-20 18:43 [PATCH 0/7] CAN: Add new PF_CAN protocol family, try #7 Urs Thuermann
2007-09-20 18:43 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-09-20 20:06   ` Joe Perches
2007-09-20 20:27     ` Thomas Gleixner
2007-09-21 10:35     ` Urs Thuermann
2007-09-21 16:58       ` Joe Perches
2007-09-24 19:23     ` Urs Thuermann
2007-09-21 12:47   ` Patrick McHardy
2007-09-21 18:01     ` Urs Thuermann
2007-09-22 10:53       ` Patrick McHardy
2007-09-17 10:03 [PATCH 0/7] CAN: Add new PF_CAN protocol family, try #6 Urs Thuermann
2007-09-17 10:03 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-09-17 15:50   ` Paul E. McKenney
2007-09-18 13:31   ` Patrick McHardy
2007-09-18 14:54     ` Urs Thuermann
2007-09-18 15:07       ` Patrick McHardy
2007-09-18 21:20     ` Urs Thuermann
2007-09-19  8:27       ` Patrick McHardy
2007-09-20  8:53         ` Urs Thuermann
2007-09-20 10:33           ` Patrick McHardy
2007-09-20 11:30             ` Urs Thuermann
2007-09-20 11:43               ` Patrick McHardy
2007-08-04  2:06 [patch 0/7] CAN: Add new PF_CAN protocol family, try #5 Urs Thuermann
2007-08-04  2:06 ` [patch 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-06-22  3:44 [patch 0/7] CAN: Add new PF_CAN protocol family, try #3 Urs Thuermann
2007-06-22  3:44 ` [patch 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-05-30 13:11 [patch 0/7] CAN: Add new PF_CAN protocol family, update Urs Thuermann
2007-05-30 13:11 ` [patch 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-05-16 14:51 [patch 0/7] CAN: Add new PF_CAN protocol family Urs Thuermann
2007-05-16 14:51 ` [patch 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-05-16 16:35   ` Arnaldo Carvalho de Melo
2007-05-16 19:14     ` Urs Thuermann
2007-05-16 20:51       ` Arnaldo Carvalho de Melo
2007-05-18  0:59   ` Paul E. McKenney
2007-05-18  9:19     ` Oliver Hartkopp
2007-05-18 14:33       ` Paul E. McKenney
2007-05-18 15:03         ` Oliver Hartkopp
2007-05-18 21:06         ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1191011298.18681.88.camel@chaos \
    --to=tglx@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=oliver.hartkopp@volkswagen.de \
    --cc=oliver@hartkopp.net \
    --cc=shemminger@linux-foundation.org \
    --cc=urs@isnogud.escape.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).