netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Corey Hickey <bugfood-ml@fatooh.org>
To: netdev@vger.kernel.org
Subject: SFQ: backport some features from ESFQ (try 4)
Date: Fri, 28 Sep 2007 15:52:47 -0700	[thread overview]
Message-ID: <1191019977201-git-send-email-bugfood-ml@fatooh.org> (raw)


Patchset try 2 addresses the review by Michael Buesch.
Patchset try 3 addresses the review by Patrick McHardy.
Patchset try 4 has a few cosmetic improvements.

Nobody reviewed my last set of patches, and I wasn't pushy about asking.
Since it's been a while, I ported the kernel and userspace patchsets to
current git of net-2.6 and iproute2, respectively.

The first 7 patches in this series resemble the corresponding 7 patches
in patchset try 2. There aren't any major changes--just modifications
to address errors noticed in review and slight reorganizations to make
the next patches easier.

Patches 8-10 implement parameter passing via nested compat attributes.
This is necessary for using 'tc qdisc change' to disable perturbation.
The rest of the parameters were added for consistency.

Iproute2 patches will follow shortly.



The following is the original patch text.

This set of patches adds some of ESFQ's modifications to the original 
SFQ. Thus far, I have received support for this approach rather than for 
trying to get ESFQ included as a separate qdisc.

http://mailman.ds9a.nl/pipermail/lartc/2007q2/021056.html

My patches here implement "tc qdisc change", user-configurable depth 
(number of flows), and user-configurable divisor (for setting hash table 
size). I've left out the remaining ESFQ features (usage of jhash and 
different hashing methods) because Patrick McHardy intends to submit a 
patch that will supersede that functionality; see the URL above.

Default values remain the same, and SFQ's default behavior remains the 
same, so there should be no user disruption.

Thanks for your consideration,
Corey



 include/linux/pkt_sched.h |   23 ++--
 net/sched/sch_sfq.c       |  353 ++++++++++++++++++++++++++++++---------------
 2 files changed, 254 insertions(+), 122 deletions(-)


[PATCH 01/10] Preparatory refactoring part 1.
[PATCH 02/10] Preparatory refactoring part 2.
[PATCH 03/10] Move two functions.
[PATCH 04/10] Make "depth" (number of queues) user-configurable:
[PATCH 05/10] Add divisor.
[PATCH 06/10] Make qdisc changeable.
[PATCH 07/10] Remove comments about hardcoded values.
[PATCH 08/10] Multiply perturb_period by HZ when used rather than when assigned.
[PATCH 09/10] Change perturb_period to unsigned.
[PATCH 10/10] Use nested compat attributes to pass parameters.

             reply	other threads:[~2007-09-28 22:53 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-28 22:52 Corey Hickey [this message]
2007-09-28 22:52 ` [PATCH 01/10] Preparatory refactoring part 1 Corey Hickey
2007-10-01 13:25   ` Patrick McHardy
2007-10-01 20:46     ` Corey Hickey
2007-10-02  3:17       ` Patrick McHardy
2007-09-28 22:52 ` [PATCH 02/10] Preparatory refactoring part 2 Corey Hickey
2007-10-01 13:33   ` Patrick McHardy
2007-10-01 20:46     ` Corey Hickey
2007-10-02  3:19       ` Patrick McHardy
2007-09-28 22:52 ` [PATCH 03/10] Move two functions Corey Hickey
2007-10-01 13:27   ` Patrick McHardy
2007-10-01 20:46     ` Corey Hickey
2007-09-28 22:52 ` [PATCH 04/10] Make "depth" (number of queues) user-configurable: Corey Hickey
2007-09-28 22:52 ` [PATCH 05/10] Add divisor Corey Hickey
2007-10-01 13:38   ` Patrick McHardy
2007-10-01 20:47     ` Corey Hickey
2007-09-28 22:52 ` [PATCH 06/10] Make qdisc changeable Corey Hickey
2007-10-01 13:43   ` Patrick McHardy
2007-10-01 20:47     ` Corey Hickey
2007-09-28 22:52 ` [PATCH 07/10] Remove comments about hardcoded values Corey Hickey
2007-09-28 22:52 ` [PATCH 08/10] Multiply perturb_period by HZ when used rather than when assigned Corey Hickey
2007-09-28 22:52 ` [PATCH 09/10] Change perturb_period to unsigned Corey Hickey
2007-10-01 13:45   ` Patrick McHardy
2007-10-01 20:47     ` Corey Hickey
2007-09-28 22:52 ` [PATCH 10/10] Use nested compat attributes to pass parameters Corey Hickey
2007-10-01 13:54   ` Patrick McHardy
2007-10-01 20:47     ` Corey Hickey
2007-10-02  3:21       ` Patrick McHardy
2007-09-28 22:54 ` sfq Corey Hickey
2007-09-28 22:57   ` sfq (iproute2 patches) Corey Hickey
2007-09-28 22:54 ` [PATCH 1/3] SFQ: Support changing depth and divisor Corey Hickey
2007-09-28 22:54 ` [PATCH 2/3] Change perturb_period to unsigned Corey Hickey
2007-09-28 22:54 ` [PATCH 3/3] Use nested compat attributes for passing parameters to the kernel Corey Hickey
2007-09-29 15:38 ` SFQ: backport some features from ESFQ (try 4) Patrick McHardy
2007-09-29 17:36   ` Corey Hickey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1191019977201-git-send-email-bugfood-ml@fatooh.org \
    --to=bugfood-ml@fatooh.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).