From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corey Hickey Subject: [PATCH 2/3] Change perturb_period to unsigned. Date: Fri, 28 Sep 2007 15:54:56 -0700 Message-ID: <11910200981065-git-send-email-bugfood-ml@fatooh.org> References: <1191019977201-git-send-email-bugfood-ml@fatooh.org> Cc: Corey Hickey To: netdev@vger.kernel.org Return-path: Received: from hot.fatooh.org ([208.78.103.127]:42968 "EHLO hot.fatooh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754593AbXI1WzG (ORCPT ); Fri, 28 Sep 2007 18:55:06 -0400 In-Reply-To: <1191019977201-git-send-email-bugfood-ml@fatooh.org> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org This corresponds to the kernel patch doing the same. Here, too, this will technically break binary compatibility with older kernels, but that shouldn't be a problem because negative perturb_period values aren't usable anyway. Signed-off-by: Corey Hickey --- include/linux/pkt_sched.h | 2 +- tc/q_sfq.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/pkt_sched.h b/include/linux/pkt_sched.h index 9d41f63..fb04a89 100644 --- a/include/linux/pkt_sched.h +++ b/include/linux/pkt_sched.h @@ -142,7 +142,7 @@ enum struct tc_sfq_qopt { unsigned quantum; /* Bytes per round allocated to flow */ - int perturb_period; /* Period of hash perturbation */ + unsigned perturb_period; /* Period of hash perturbation */ __u32 limit; /* Maximal packets in queue */ unsigned divisor; /* Hash divisor */ unsigned flows; /* Maximal number of flows */ diff --git a/tc/q_sfq.c b/tc/q_sfq.c index 7754db7..c9fcc53 100644 --- a/tc/q_sfq.c +++ b/tc/q_sfq.c @@ -47,7 +47,7 @@ static int sfq_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct nl ok++; } else if (strcmp(*argv, "perturb") == 0) { NEXT_ARG(); - if (get_integer(&opt.perturb_period, *argv, 0)) { + if (get_u32(&opt.perturb_period, *argv, 0)) { fprintf(stderr, "Illegal \"perturb\"\n"); return -1; } @@ -115,7 +115,7 @@ static int sfq_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) fprintf(f, "flows %u/%u ", qopt->flows, qopt->divisor); } if (qopt->perturb_period) - fprintf(f, "perturb %dsec ", qopt->perturb_period); + fprintf(f, "perturb %usec ", qopt->perturb_period); return 0; } -- 1.5.3